Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MediaPackage Channel resource #6957

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Added MediaPackage Channel resource #6957

merged 2 commits into from
Jan 8, 2019

Conversation

sjauld
Copy link
Contributor

@sjauld sjauld commented Dec 21, 2018

Fixes #6930
Changes proposed in this pull request:

  • New resource: AWS Elemental MediaPackage Channel

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMediaPackageChannel_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAWSMediaPackageChannel_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSMediaPackageChannel_basic
=== PAUSE TestAccAWSMediaPackageChannel_basic
=== CONT  TestAccAWSMediaPackageChannel_basic
--- PASS: TestAccAWSMediaPackageChannel_basic (14.30s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       14.427s
...

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 21, 2018
@bflad bflad added service/mediapackage Issues and PRs that pertain to the mediapackage service. new-resource Introduces a new resource. labels Dec 21, 2018
bflad
bflad reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sjauld 👋 Thanks for submitting this! Please see the below initial feedback and let us know if you have any questions or do not have time to implement the items. 😸

website/docs/r/media_package_channel.html.markdown Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Outdated Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Outdated Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Outdated Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Outdated Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Outdated Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Outdated Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Show resolved Hide resolved
aws/resource_aws_media_package_channel.go Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 21, 2018
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 3, 2019
@sjauld
Copy link
Contributor Author

sjauld commented Jan 3, 2019

Thanks for the feedback @bflad - should be good to go I think?

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAWSMediaPackageChannel -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSMediaPackageChannel_basic
=== PAUSE TestAccAWSMediaPackageChannel_basic
=== RUN   TestAccAWSMediaPackageChannel_description
=== PAUSE TestAccAWSMediaPackageChannel_description
=== CONT  TestAccAWSMediaPackageChannel_basic
=== CONT  TestAccAWSMediaPackageChannel_description
--- PASS: TestAccAWSMediaPackageChannel_basic (18.30s)
--- PASS: TestAccAWSMediaPackageChannel_description (29.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       29.868s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 3, 2019
bflad
bflad approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @sjauld! I'll take care of the super minor docs update on merge so we can get this released. 🚀

--- PASS: TestAccAWSMediaPackageChannel_basic (10.88s)
--- PASS: TestAccAWSMediaPackageChannel_description (16.60s)

website/docs/r/media_package_channel.html.markdown

* `id` - The same as `channel_id`
* `arn` - The ARN of the channel
* `ingest_endpoints` - A list of the ingest endpoints (see below)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This was updated to hls_ingest.0.ingest_endpoints, can fix on merge. 😄

@bflad bflad added this to the v1.55.0 milestone Jan 8, 2019
@bflad bflad merged commit 9d52431 into hashicorp:master Jan 8, 2019
bflad added a commit that referenced this pull request Jan 8, 2019
@bflad
Update CHANGELOG for #6957
4ed9b76
@bflad
Copy link
Contributor

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/mediapackage Issues and PRs that pertain to the mediapackage service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.55.0
Development

Successfully merging this pull request may close these issues.

New resource: aws_media_package_channel
2 participants
@sjauld @bflad