r/aws_s3_bucket: Support S3 Object Lock

[ewbankkit]

Fixes #6872.

Syntax:

resource "aws_s3_bucket" "foo" {
  bucket = "my-versioning-bucket"
  acl    = "private"

  object_lock_configuration {
    object_lock_enabled = "Enabled"

    rule {
      default_retention {
        mode = "GOVERNANCE"
        days = 30
      }
    }
  }
}

[ewbankkit]

Pushing initial work as I will be OOTO for the next 2 weeks.

[ewbankkit]

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_objectLock'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSS3Bucket_objectLock -timeout 120m
=== RUN   TestAccAWSS3Bucket_objectLock
=== PAUSE TestAccAWSS3Bucket_objectLock
=== CONT  TestAccAWSS3Bucket_objectLock
--- PASS: TestAccAWSS3Bucket_objectLock (54.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	54.035s

[ewbankkit]

Updates to aws_s3_bucket_object resource will be in a separate PR.
Removing WIP - @bflad now ready for review.

[bflad]

Hey @ewbankkit 👋 This is looking pretty good! One minor attribute change and I think we might want to include some of the limitations/oddities about this configuration in the resource documentation.

[ewbankkit]

Acceptance tests after code review changes:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_objectLock'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSS3Bucket_objectLock -timeout 120m
=== RUN   TestAccAWSS3Bucket_objectLock
=== PAUSE TestAccAWSS3Bucket_objectLock
=== CONT  TestAccAWSS3Bucket_objectLock
--- PASS: TestAccAWSS3Bucket_objectLock (59.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	74.381s

[bflad]

Looks great, @ewbankkit, thanks! 🚀

Passes all S3 bucket acceptance testing over various runs (when eventual consistency is not acting up).

[bflad]

This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!