Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import support for aws_iam_user_group_membership resource #6976

Conversation

teraken0509
Copy link
Contributor

Fixes #6698

Changes proposed in this pull request:

  • Add import support for aws_iam_user_group_membership

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSUserGroupMembership_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSUserGroupMembership_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSUserGroupMembership_basic
=== PAUSE TestAccAWSUserGroupMembership_basic
=== CONT  TestAccAWSUserGroupMembership_basic
--- PASS: TestAccAWSUserGroupMembership_basic (108.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	(cached)
...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 24, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 8, 2019
@bflad bflad added this to the v2.6.0 milestone Apr 8, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSUserGroupMembership_basic (30.31s)

@bflad bflad merged commit 9a94efa into hashicorp:master Apr 8, 2019
bflad added a commit that referenced this pull request Apr 8, 2019
@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@jason-colby-brown
Copy link

Is there a plan to add the same support for the 'aws_iam_group_membership' resource?

@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

@jason-colby-brown thanks for asking. Please open a new feature request GitHub issue so that work can be appropriately tracked.

@teraken0509 teraken0509 deleted the feature/add-import-aws_iam_user_group_membership branch March 5, 2020 14:01
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for import for iam_user_group_membership
3 participants