Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tags for aws_sfn_state_machine and aws_sfn_activity #7024

Merged
merged 6 commits into from
Jan 10, 2019
Merged

Add support for tags for aws_sfn_state_machine and aws_sfn_activity #7024

merged 6 commits into from
Jan 10, 2019

Conversation

sunilkumarmohanty
Copy link
Contributor

@sunilkumarmohanty sunilkumarmohanty commented Jan 3, 2019 •
edited
Loading

As part of #6971

Changes proposed in this pull request:

  • Tag support for aws_sfn_state_machine and aws_sfn_activity

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSfnStateMachine_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSfnStateMachine_Tags -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSfnStateMachine_Tags
=== PAUSE TestAccAWSSfnStateMachine_Tags
=== CONT  TestAccAWSSfnStateMachine_Tags
--- PASS: TestAccAWSSfnStateMachine_Tags (95.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       95.384s...



make testacc TESTARGS='-run=TestAccAWSSfnActivity_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSfnActivity_Tags -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSfnActivity_Tags
=== PAUSE TestAccAWSSfnActivity_Tags
=== CONT  TestAccAWSSfnActivity_Tags
--- PASS: TestAccAWSSfnActivity_Tags (50.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.171s

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. service/sfn Issues and PRs that pertain to the sfn service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 3, 2019
@sunilkumarmohanty sunilkumarmohanty changed the title Sfn tag Add support for tags for aws_sfn_state_machine Jan 3, 2019
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Jan 3, 2019
@sunilkumarmohanty sunilkumarmohanty changed the title Add support for tags for aws_sfn_state_machine Add support for tags for aws_sfn_state_machine and aws_sfn_activity Jan 3, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed dependencies Used to indicate dependency changes. labels Jan 4, 2019
bflad
bflad reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunilkumarmohanty 👋 Thanks for submitting this! Please see the below feedback items and let us know if you have any questions or do not have time to address them.

aws/resource_aws_sfn_activity.go Outdated Show resolved Hide resolved
aws/resource_aws_sfn_activity.go Show resolved Hide resolved
aws/resource_aws_sfn_state_machine.go Outdated Show resolved Hide resolved
aws/resource_aws_sfn_state_machine.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 8, 2019
@sunilkumarmohanty
Copy link
Contributor Author

@bflad I am sorry, I forgot to make these changes. It is done now.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 10, 2019
@bflad bflad added this to the v1.55.0 milestone Jan 10, 2019
bflad
bflad approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sunilkumarmohanty! 🚀

(Test failure unrelated)

--- PASS: TestAccAWSSfnActivity_importBasic (4.19s)
--- PASS: TestAccAWSSfnActivity_basic (5.35s)
--- PASS: TestAccAWSSfnActivity_Tags (9.64s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (26.11s)
--- PASS: TestAccAWSSfnStateMachine_Tags (31.51s)

@bflad bflad merged commit 0ef5ea2 into hashicorp:master Jan 10, 2019
bflad added a commit that referenced this pull request Jan 10, 2019
@bflad
Update CHANGELOG for #7024
0f24a2f
@bflad
Copy link
Contributor

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.55.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sunilkumarmohanty @bflad