Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_kinesis_analytics_application: Retry Lambda permission InvalidArgumentException errors for eventual consistency #7039

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 5, 2019

Fixes #7032

Changes:

  • tests/resource/aws_kinesis_analytics_application: Add acceptance testing for outputs lambda arguments
  • resource/aws_kinesis_analytics_application: Retry Create/Update on InvalidArgumentException: Given IAM role arn : xxx does not provide Invoke permissions on the Lambda resource : yyy for IAM eventual consistency

Previously from acceptance testing:

--- FAIL: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (30.03s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_kinesis_analytics_application.test: 1 error occurred:
        	* aws_kinesis_analytics_application.test: Unable to create Kinesis Analytics application: InvalidArgumentException: Given IAM role arn : arn:aws:iam::123456789012:role/tf-acc-test-8964136865322641182-kinesis does not provide Invoke permissions on the Lambda resource : arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-8964136865322641182

Output from acceptance testing:

--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (35.37s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (36.38s)

…nvalidArgumentException errors for eventual consistency

Changes:
* tests/resource/aws_kinesis_analytics_application: Add acceptance testing for `outputs` `lambda` arguments
* resource/aws_kinesis_analytics_application: Retry Create/Update on `InvalidArgumentException: Given IAM role arn : xxx does not provide Invoke permissions on the Lambda resource : yyy` for IAM eventual consistency

Previously from acceptance testing:

```
--- FAIL: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (30.03s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_kinesis_analytics_application.test: 1 error occurred:
        	* aws_kinesis_analytics_application.test: Unable to create Kinesis Analytics application: InvalidArgumentException: Given IAM role arn : arn:aws:iam::123456789012:role/tf-acc-test-8964136865322641182-kinesis does not provide Invoke permissions on the Lambda resource : arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-8964136865322641182
```

Output from acceptance testing:

```
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (35.37s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (36.38s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. labels Jan 5, 2019
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 5, 2019
@bflad bflad requested a review from a team January 5, 2019 03:42
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.55.0 milestone Jan 7, 2019
@bflad bflad merged commit c90ebac into master Jan 7, 2019
@bflad bflad deleted the b-aws_kinesis_analytics_application-lambda-retries branch January 7, 2019 13:15
bflad added a commit that referenced this pull request Jan 7, 2019
@bflad
Copy link
Contributor Author

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create Kinesis Analytics application: InvalidArgumentException
2 participants