Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_dynamodb_table: Fix table creation in GovCloud (US) and China due to missing BillingMode support #7064

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 8, 2019

Fixes #6919

Previous output from acceptance testing (AWS GovCloud (US), all aws_dynamodb_table tests):

--- FAIL: TestAccAWSDynamoDbTable_basic (0.39s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: ValidationException: One or more parameter values were invalid: Unsupported input parameter BillingMode

Output from acceptance testing (AWS GovCloud (US), no new failures from pre-BillingMode):

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (3.64s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (5.13s)
--- FAIL: TestAccAWSDynamoDbTable_encryption (5.43s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: error creating DynamoDB Table: ValidationException: One or more parameter values were invalid: Unsupported input parameter SSESpecification
        	status code: 400, request id: F6OSK8MN7T1JOG2S5E30GSHN4VVV4KQNSO5AEMVJF66Q9ASUAAJG

--- PASS: TestAccAWSDynamoDbTable_basic (25.22s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (41.12s)
--- PASS: TestAccAWSDynamoDbTable_importTags (47.65s)
--- PASS: TestAccAWSDynamoDbTable_ttl (56.96s)
--- FAIL: TestAccAWSDynamoDbTable_enablePitr (61.74s)
    testing.go:538: Step 1 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: UnknownOperationException: Unknown operation exception
        	status code: 400, request id: 0DN6K5DCG70T8SFDVEH7B0GJ9BVV4KQNSO5AEMVJF66Q9ASUAAJG

--- PASS: TestAccAWSDynamoDbTable_tags (72.81s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (74.31s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (105.10s)
--- PASS: TestAccAWSDynamoDbTable_importTimeToLive (106.13s)
--- FAIL: TestAccAWSDynamoDbTable_BillingMode (116.25s)
    testing.go:538: Step 1 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: error creating DynamoDB Table: ValidationException: One or more parameter values were invalid: Missing required parameter in input: "ProvisionedThroughput"
        	status code: 400, request id: 2BEOP0E6AD39707F43EEMDED1FVV4KQNSO5AEMVJF66Q9ASUAAJG

--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (289.91s)
--- PASS: TestAccAWSDynamoDbTable_extended (292.16s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (586.40s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (589.72s)

…China due to missing BillingMode support

Previous output from acceptance testing (AWS GovCloud (US), all aws_dynamodb_table tests):

```
--- FAIL: TestAccAWSDynamoDbTable_basic (0.39s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: ValidationException: One or more parameter values were invalid: Unsupported input parameter BillingMode
```

Output from acceptance testing (AWS GovCloud (US), no new failures from pre-BillingMode):

```
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (3.64s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (5.13s)
--- FAIL: TestAccAWSDynamoDbTable_encryption (5.43s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: error creating DynamoDB Table: ValidationException: One or more parameter values were invalid: Unsupported input parameter SSESpecification
        	status code: 400, request id: F6OSK8MN7T1JOG2S5E30GSHN4VVV4KQNSO5AEMVJF66Q9ASUAAJG

--- PASS: TestAccAWSDynamoDbTable_basic (25.22s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (41.12s)
--- PASS: TestAccAWSDynamoDbTable_importTags (47.65s)
--- PASS: TestAccAWSDynamoDbTable_ttl (56.96s)
--- FAIL: TestAccAWSDynamoDbTable_enablePitr (61.74s)
    testing.go:538: Step 1 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: UnknownOperationException: Unknown operation exception
        	status code: 400, request id: 0DN6K5DCG70T8SFDVEH7B0GJ9BVV4KQNSO5AEMVJF66Q9ASUAAJG

--- PASS: TestAccAWSDynamoDbTable_tags (72.81s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (74.31s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (105.10s)
--- PASS: TestAccAWSDynamoDbTable_importTimeToLive (106.13s)
--- FAIL: TestAccAWSDynamoDbTable_BillingMode (116.25s)
    testing.go:538: Step 1 error: Error applying: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: 1 error occurred:
        	* aws_dynamodb_table.basic-dynamodb-table: error creating DynamoDB Table: ValidationException: One or more parameter values were invalid: Missing required parameter in input: "ProvisionedThroughput"
        	status code: 400, request id: 2BEOP0E6AD39707F43EEMDED1FVV4KQNSO5AEMVJF66Q9ASUAAJG

--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (289.91s)
--- PASS: TestAccAWSDynamoDbTable_extended (292.16s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (586.40s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (589.72s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Jan 8, 2019
@bflad bflad requested a review from a team January 8, 2019 14:05
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jan 8, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v1.55.0 milestone Jan 8, 2019
@bflad bflad merged commit cd5f835 into master Jan 8, 2019
@bflad bflad deleted the b-aws_dynamodb_table-govcloud branch January 8, 2019 15:47
bflad added a commit that referenced this pull request Jan 8, 2019
@bflad
Copy link
Contributor Author

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partition/aws-us-gov Pertains to the aws-us-gov partition. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dynamodb_table fails in govcloud after BillingMode support added in #6648
2 participants