Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IAM Role Policy No Such Entity Exception Handling #7070

Conversation

teraken0509
Copy link
Contributor

Changes proposed in this pull request:

  • aws_iam_role_policy skip error when NoSuchEntity error occured while deleting.
  • Add test case

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMRolePolicy_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSIAMRolePolicy_disappears -timeout 120m
=== RUN   TestAccAWSIAMRolePolicy_disappears
=== PAUSE TestAccAWSIAMRolePolicy_disappears
=== CONT  TestAccAWSIAMRolePolicy_disappears
--- PASS: TestAccAWSIAMRolePolicy_disappears (29.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws    29.580s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 9, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jan 9, 2019
@bflad bflad added this to the v1.55.0 milestone Jan 9, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509! 🚀

--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (0.92s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (7.40s)
--- PASS: TestAccAWSIAMRolePolicy_importBasic (8.52s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (12.79s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (12.89s)
--- PASS: TestAccAWSIAMRolePolicy_basic (13.32s)

@bflad bflad merged commit 43f2514 into hashicorp:master Jan 9, 2019
bflad added a commit that referenced this pull request Jan 9, 2019
@bflad
Copy link
Contributor

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/fix-iam-role-policy-no-such-entity-exception branch March 5, 2020 14:06
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants