Fix error handling of aws_iam_policy resouce

[teraken0509]

Fixes #35

Changes proposed in this pull request:

• Fix Error handling at delete
• Add test function

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSIAMPolicy_ -timeout 120m
=== RUN   TestAccAWSIAMPolicy_basic
=== PAUSE TestAccAWSIAMPolicy_basic
=== RUN   TestAccAWSIAMPolicy_description
=== PAUSE TestAccAWSIAMPolicy_description
=== RUN   TestAccAWSIAMPolicy_disappears
=== PAUSE TestAccAWSIAMPolicy_disappears
=== RUN   TestAccAWSIAMPolicy_namePrefix
=== PAUSE TestAccAWSIAMPolicy_namePrefix
=== RUN   TestAccAWSIAMPolicy_path
=== PAUSE TestAccAWSIAMPolicy_path
=== RUN   TestAccAWSIAMPolicy_policy
=== PAUSE TestAccAWSIAMPolicy_policy
=== CONT  TestAccAWSIAMPolicy_basic
=== CONT  TestAccAWSIAMPolicy_path
=== CONT  TestAccAWSIAMPolicy_disappears
=== CONT  TestAccAWSIAMPolicy_namePrefix
=== CONT  TestAccAWSIAMPolicy_policy
=== CONT  TestAccAWSIAMPolicy_description
--- PASS: TestAccAWSIAMPolicy_disappears (21.67s)
--- PASS: TestAccAWSIAMPolicy_path (32.46s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (32.50s)
--- PASS: TestAccAWSIAMPolicy_basic (32.52s)
--- PASS: TestAccAWSIAMPolicy_description (32.51s)
--- PASS: TestAccAWSIAMPolicy_policy (51.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	51.572s

[bflad]

@kterada0509 can you explain what was fixed with this?

Fix Error handling at delete

The resource logic appears to be the same. As an aside, we'd prefer the original left aligned style over the nested style inside the conditional.

The additional test is definitely appreciated though. 👍

[bflad]

Ahh. Looking at #35 and the commit a few years ago that actually should've closed the original hashicorp/terraform issue: 38e096a

Its the %#v to %s formatting change for err. 💯 Assuming tests pass we'll get this in.

[bflad]

LGTM, thanks @kterada0509! 🚀

--- PASS: TestAccAWSIAMPolicy_disappears (5.39s)
--- PASS: TestAccAWSIAMPolicy_path (8.80s)
--- PASS: TestAccAWSIAMPolicy_description (8.86s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (8.96s)
--- PASS: TestAccAWSIAMPolicy_basic (8.96s)
--- PASS: TestAccAWSIAMPolicy_policy (14.56s)

[bflad]

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!