Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_app_cookie_stickiness_policy: Properly read lb_port into Terraform state and support resource import #7080

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 10, 2019

Previously with TF_SCHEMA_PANIC_ON_ERROR=1:

panic: lb_port: '' expected type 'int', got unconvertible type 'string'

goroutine 636 [running]:
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*ResourceData).Set(0xc00022f030, 0x3c65264, 0x7, 0x3152440, 0xc00004cf60, 0x0, 0x0)
	/opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/resource_data.go:191 +0x334
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAppCookieStickinessPolicyRead(0xc00022f030, 0x36595a0, 0xc000a68a80, 0xc00022f030, 0x0)
	/opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_app_cookie_stickiness_policy.go:139 +0x4de

Output from acceptance testing:

--- PASS: TestAccAWSAppCookieStickinessPolicy_drift (32.27s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_missingLB (32.81s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_basic (34.11s)

… Terraform state and support resource import

Previously with `TF_SCHEMA_PANIC_ON_ERROR=1`:

```
panic: lb_port: '' expected type 'int', got unconvertible type 'string'

goroutine 636 [running]:
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*ResourceData).Set(0xc00022f030, 0x3c65264, 0x7, 0x3152440, 0xc00004cf60, 0x0, 0x0)
	/opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/resource_data.go:191 +0x334
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAppCookieStickinessPolicyRead(0xc00022f030, 0x36595a0, 0xc000a68a80, 0xc00022f030, 0x0)
	/opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_app_cookie_stickiness_policy.go:139 +0x4de
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAppCookieStickinessPolicy_drift (32.27s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_missingLB (32.81s)
--- PASS: TestAccAWSAppCookieStickinessPolicy_basic (34.11s)
```
@bflad bflad added the service/elb Issues and PRs that pertain to the elb service. label Jan 10, 2019
@bflad bflad requested a review from a team January 10, 2019 01:35
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 10, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.55.0 milestone Jan 10, 2019
@bflad bflad merged commit 7dff1d4 into master Jan 10, 2019
@bflad bflad deleted the b-aws_app_cookie_stickiness_policy-schema-panic branch January 10, 2019 14:53
bflad added a commit that referenced this pull request Jan 10, 2019
@bflad
Copy link
Contributor Author

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants