New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support docdb cluster parameter group resource #7090

Merged

bflad merged 4 commits into hashicorp:master from teraken0509:feature/add-support-docdb-cluster-parameter-group-resource

Jan 10, 2019

Contributor

teraken0509 commented Jan 10, 2019 •

edited by bflad

Loading

Reference #7077

Changes proposed in this pull request:

Add docdb tag resource
Add resource aws_docdb_cluster_parameter_group

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDocDBClusterParameterGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDocDBClusterParameterGroup_ -timeout 120m
=== RUN   TestAccAWSDocDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDocDBClusterParameterGroup_basic
=== RUN   TestAccAWSDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDocDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDocDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDocDBClusterParameterGroup_Description
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Description
=== RUN   TestAccAWSDocDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDocDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_Parameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Parameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_Tags
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Tags
=== CONT  TestAccAWSDocDBClusterParameterGroup_basic
=== CONT  TestAccAWSDocDBClusterParameterGroup_disappears
=== CONT  TestAccAWSDocDBClusterParameterGroup_Tags
=== CONT  TestAccAWSDocDBClusterParameterGroup_Parameter
=== CONT  TestAccAWSDocDBClusterParameterGroup_generatedName
=== CONT  TestAccAWSDocDBClusterParameterGroup_Description
=== CONT  TestAccAWSDocDBClusterParameterGroup_namePrefix
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (23.16s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (33.17s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (33.18s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (33.30s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (33.41s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (51.23s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (69.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.561s
...

teraken0509 added 2 commits

January 10, 2019 19:00


          Add docdb connection config

5a46231


          Add docDB tag functions

b0898b5

ghost added size/XXL documentation provider tests labels

teraken0509 force-pushed the feature/add-support-docdb-cluster-parameter-group-resource branch from 1636444 to c1878a4 Compare

January 10, 2019 10:11

ewbankkit mentioned this pull request

Feature request: Support Amazon DocumentDB #7077

Closed

okonon commented Jan 10, 2019 •

edited

Loading

@ewbankkit @kterada0509 this is awesome and thanks for your quick turnaround!!!! long awaited feature for us

okonon commented Jan 10, 2019

@kterada0509 @ewbankkit does this support encryption at rest --storage-encrypted ?

bflad reviewed

View reviewed changes

Contributor

bflad left a comment

Hey @kterada0509! Thanks for submitting this. A few minor things and should be good to go. 👍

aws/resource_aws_docdb_cluster_parameter_group.go Show resolved Hide resolved

aws/resource_aws_docdb_cluster_parameter_group.go Outdated

    
              	}

              	d.SetId(aws.StringValue(createOpts.DBClusterParameterGroupName))

              	log.Printf("[INFO] Neptune Cluster Parameter Group ID: %s", d.Id())

Contributor

bflad Jan 10, 2019

Copypasta 🍝 and we really don't need this log line 👍

Contributor Author

teraken0509 Jan 10, 2019

Removed logging

aws/resource_aws_docdb_cluster_parameter_group.go

    
              	d.SetId(aws.StringValue(createOpts.DBClusterParameterGroupName))

              	log.Printf("[INFO] Neptune Cluster Parameter Group ID: %s", d.Id())

              	d.Set("arn", resp.DBClusterParameterGroup.DBClusterParameterGroupArn)

Contributor

bflad Jan 10, 2019

Maintainer note: for consistency reasons with RDS/Neptune, setting arn in the Create here and calling Update after Create is okay for now -- they will all get similar fixes in the future.

aws/resource_aws_docdb_cluster_parameter_group.go Outdated

    
              	describeParametersResp, err := conn.DescribeDBClusterParameters(describeParametersOpts)

              	if err != nil {

              		return err

Contributor

bflad Jan 10, 2019

Nit: It'd be nice to return error context here for operators and code maintainers

Suggested change

      
            		return err
          
            		return fmt.Errorf("error reading DocDB Cluster Parameter Group (%s) parameters: %s", d.Id(), err)

Contributor Author

teraken0509 Jan 10, 2019

Fixed

aws/resource_aws_docdb_cluster_parameter_group.go Outdated

    
              	})

              	if err != nil {

              		log.Printf("[DEBUG] Error retrieving tags for ARN: %s", arn)

Contributor

bflad Jan 10, 2019

We should return an error here instead of a debug log:

Suggested change

      
            		log.Printf("[DEBUG] Error retrieving tags for ARN: %s", arn)
          
            		return fmt.Errorf("error listing tags for DocDB Cluster Parameter Group (%s): %s", d.Id(), err)

Contributor Author

teraken0509 Jan 10, 2019

Fixed

website/docs/r/docdb_cluster_parameter_group.html.markdown Outdated

    
                description = "docdb cluster parameter group"

                parameter {

                  name  = "neptune_enable_audit_log"

Contributor

bflad Jan 10, 2019

Copypasta 🍝 Lets pick a DocDB one 😄 https://docs.aws.amazon.com/documentdb/latest/developerguide/db-cluster-parameters.html

Suggested change

      
                name  = "neptune_enable_audit_log"
          
                name  = "tls"

Contributor Author

teraken0509 Jan 10, 2019

Fixed

website/docs/r/docdb_cluster_parameter_group.html.markdown Outdated

    
                parameter {

                  name  = "neptune_enable_audit_log"

                  value = 1

Contributor

bflad Jan 10, 2019

And a matching value from our testing 😉

Suggested change

      
                value = 1
          
                value = "enabled"

Contributor Author

teraken0509 Jan 10, 2019

Fixed

website/aws.erb Outdated

    
                                  <ul class="nav nav-visible">

                                      <li<%= sidebar_current("docs-aws-resource-docdb-cluster-parameter-group") %>>

                                          <a href="/docs/providers/aws/r/docdb_cluster_parameter_group.html">aws_dax_cluster</a>

Contributor

bflad Jan 10, 2019

Copypasta 🍝

Suggested change

      
                                        <a href="/docs/providers/aws/r/docdb_cluster_parameter_group.html">aws_dax_cluster</a>
          
                                        <a href="/docs/providers/aws/r/docdb_cluster_parameter_group.html">aws_docdb_cluster_parameter_group</a>

Contributor Author

teraken0509 Jan 10, 2019

Fixed

bflad added waiting-response new-resource labels

Contributor

bflad commented Jan 10, 2019

I'd also change your PR comment to Reference: #7077 since this shouldn't close the issue. 😉


          Add aws_docdb_cluster_parameter_group resource

4b472df

teraken0509 force-pushed the feature/add-support-docdb-cluster-parameter-group-resource branch from c1878a4 to a31ec1b Compare

January 10, 2019 16:55

Contributor

ewbankkit commented Jan 10, 2019

@okonon All kudos to @kterada0509 for this, I just opened the issue 😄.
It looks like DocumentDB encryption-at-rest is configured when creating the cluster so this will be an attribute of the aws_docdb_cluster resource.

ghost removed the waiting-response label


          Add aws_docdb_cluster_parameter_group resource document

940943b

teraken0509 force-pushed the feature/add-support-docdb-cluster-parameter-group-resource branch from a31ec1b to 940943b Compare

January 10, 2019 17:00

Contributor Author

teraken0509 commented Jan 10, 2019

@bflad
Thanks for review.
I fixed your review.

bflad added this to the v1.55.0 milestone

bflad approved these changes

View reviewed changes

Contributor

bflad left a comment

Great work, @kterada0509, thanks! 🚀

--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (3.16s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (4.73s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (4.74s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (4.77s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (4.78s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (12.20s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (12.53s)

bflad merged commit 8d937ec into hashicorp:master

bflad added a commit that referenced this pull request


          Update CHANGELOG for #7090

c757e3c

teraken0509 mentioned this pull request

Add support docdb subnet group resource #7106

Merged

Contributor

bflad commented Jan 10, 2019

This has been released in version 1.55.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

teraken0509 deleted the feature/add-support-docdb-cluster-parameter-group-resource branch

March 5, 2020 14:03

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation new-resource provider size/XXL tests