Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6785] aws_opsworks_custom_layer should support encrypted ebs_volume configurations #7110

Merged
merged 1 commit into from
Dec 17, 2019
Merged

[#6785] aws_opsworks_custom_layer should support encrypted ebs_volume configurations #7110

merged 1 commit into from
Dec 17, 2019

Conversation

dclark
Copy link
Contributor

@dclark dclark commented Jan 10, 2019

Adds an encrypted boolean option to the aws_opsworks_custom_layer
default set to false and set as optional for backward compatibility and tests added.

Output from acceptance testing:

=== RUN TestAccAWSOpsworksCustomLayer_importBasic
=== PAUSE TestAccAWSOpsworksCustomLayer_importBasic
=== RUN TestAccAWSOpsworksCustomLayer_basic
=== PAUSE TestAccAWSOpsworksCustomLayer_basic
=== CONT TestAccAWSOpsworksCustomLayer_importBasic
--- PASS: TestAccAWSOpsworksCustomLayer_importBasic (68.78s)
=== CONT TestAccAWSOpsworksCustomLayer_basic
--- PASS: TestAccAWSOpsworksCustomLayer_basic (69.50s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 138.301s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/opsworks Issues and PRs that pertain to the opsworks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 10, 2019
@dclark dclark mentioned this pull request Jan 10, 2019
Closed
@relu
Copy link
Contributor

relu commented Feb 1, 2019

Any chance of this getting into the next release? :)

@aeschright aeschright requested a review from a team June 25, 2019 21:45
@leonsodhi-lf
Copy link

@aeschright I know there are a vast number of open PRs ATM - I can only imagine how difficult it is to keep up - but as this is a small change and it's been open for a while, is there any chance of it being merged in the near future?

@aeschright
Copy link
Contributor

Hi! This looks pretty straightforward for us to accept, but there's a merge conflict that @dclark will need to resolve, then run the tests again.

@dclark
Copy link
Contributor Author

dclark commented Dec 13, 2019

@aeschright I'll look into this and resolve.

@dclark dclark force-pushed the feature/aws-opsworks-custom-layer-encrypted-ebs-volume-support-issue-6785 branch 2 times, most recently from 1063ccd to c588cce Compare December 13, 2019 20:43
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 13, 2019
@aeschright aeschright self-assigned this Dec 13, 2019
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 13, 2019
@dclark
[hashicorp#6785] aws_opsworks_custom_layer should support `encrypte…
052155d 
…d` `ebs_volume` configurations.

 * Adds an encrypted boolean option to the aws_opsworks_custom_layer
 * default set to false and set as optional for backward compatibility and tests added.
 * Remove unnecessary conversion (unconvert)
 * Add encrypted option to the aws opsworks custom layer ebs volume documentation
@dclark dclark force-pushed the feature/aws-opsworks-custom-layer-encrypted-ebs-volume-support-issue-6785 branch from 47260eb to 052155d Compare December 13, 2019 21:42
@dclark
Copy link
Contributor Author

dclark commented Dec 13, 2019 •
edited
Loading

@aeschright Pull request has been updated.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSOpsworksCustomLayer_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 5 -run=TestAccAWSOpsworksCustomLayer_basic -timeout 120m
=== RUN TestAccAWSOpsworksCustomLayer_basic
=== PAUSE TestAccAWSOpsworksCustomLayer_basic
=== CONT TestAccAWSOpsworksCustomLayer_basic
--- PASS: TestAccAWSOpsworksCustomLayer_basic (75.02s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 75.042s

make testacc TEST=./aws TESTARGS='-run=TestAccAWSOpsworksCustomLayer_noVPC'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 5 -run=TestAccAWSOpsworksCustomLayer_noVPC -timeout 120m
=== RUN TestAccAWSOpsworksCustomLayer_noVPC
=== PAUSE TestAccAWSOpsworksCustomLayer_noVPC
=== CONT TestAccAWSOpsworksCustomLayer_noVPC
--- PASS: TestAccAWSOpsworksCustomLayer_noVPC (79.25s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 79.282s

aeschright
aeschright approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌟

--- PASS: TestAccAWSOpsworksCustomLayer_basic (31.39s)
--- PASS: TestAccAWSOpsworksCustomLayer_noVPC (45.40s)

@aeschright aeschright merged commit 972f39d into hashicorp:master Dec 17, 2019
aeschright added a commit that referenced this pull request Dec 17, 2019
@aeschright
Update Changelog for #7110
d5fe1ed
@bflad
Copy link
Contributor

bflad commented Dec 18, 2019

@aeschright adding to this release's milestone (v2.43.0) and closing the associated feature request (#6785)

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 18, 2019
@bflad bflad added this to the v2.43.0 milestone Dec 18, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees

@aeschright aeschright

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/opsworks Issues and PRs that pertain to the opsworks service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.43.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dclark @relu @leonsodhi-lf @aeschright @bflad