resource/aws_inspector_assessment_target: Various enhancements and fixes #7112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * resource/aws_inspector_assessment_target: Allow omitting `resource_group_arn` argument (support matching all EC2 instances) * resource/aws_inspector_assessment_target: Support resource import * resource/aws_inspector_assessment_target: Properly read `resource_group_arn` attribute into Terraform state * tests/resource/aws_inspector_assessment_target: Add acceptance test to verify external resource deletion handling Output from acceptance testing: ``` --- PASS: TestAccAWSInspectorTarget_disappears (8.38s) --- PASS: TestAccAWSInspectorTarget_basic (12.09s) --- PASS: TestAccAWSInspectorTarget_Name (19.02s) --- PASS: TestAccAWSInspectorTarget_ResourceGroupArn (36.29s) ```
bflad
added
bug
ghost
added
size/XL
bflad
deleted the
f-aws_inspector_assessment_target-import-and-all-instances
branch
bflad
added a commit
that referenced
this pull request
Jan 11, 2019
|
This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easiest just to bundle all the updates together.
Changes:
resource_group_arnargument (support matching all EC2 instances)resource_group_arnattribute into Terraform stateOutput from acceptance testing: