Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_elastic_beanstalk_application Data Source #7144

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Add aws_elastic_beanstalk_application Data Source #7144

merged 1 commit into from
Jan 15, 2019

Conversation

teraken0509
Copy link
Contributor

Fixes #3838

Changes proposed in this pull request:

  • Add data source aws_elastic_beanstalk_application

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsElasticBeanstalkApplicationDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsElasticBeanstalkApplicationDataSource_basic -timeout 120m
=== RUN   TestAccAwsElasticBeanstalkApplicationDataSource_basic
=== PAUSE TestAccAwsElasticBeanstalkApplicationDataSource_basic
=== CONT  TestAccAwsElasticBeanstalkApplicationDataSource_basic
--- PASS: TestAccAwsElasticBeanstalkApplicationDataSource_basic (34.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.452s

@ghost ghost added provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 15, 2019
@bflad bflad added the new-data-source Introduces a new data source. label Jan 15, 2019
@bflad bflad added this to the v1.56.0 milestone Jan 15, 2019
bflad
bflad approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking nit, thanks @kterada0509 🚀

--- PASS: TestAccAwsElasticBeanstalkApplicationDataSource_basic (8.61s)

aws/data_source_aws_elastic_beanstalk_application.go
"name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ForceNew: true is extraneous for data sources

@bflad bflad merged commit 7a1025a into hashicorp:master Jan 15, 2019
bflad added a commit that referenced this pull request Jan 15, 2019
@bflad
Update CHANGELOG for #7144
a3f9437
@bflad
Copy link
Contributor

bflad commented Jan 16, 2019

This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-elastic_beanstalk_application-data-source branch March 5, 2020 14:01
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.56.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Elastic Beanstalk Application Data Source
2 participants
@teraken0509 @bflad