Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ses_identity_notification_topic: add support for include_original_headers #7293

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

oleg-codaio
Copy link
Contributor

Fixes #4376

Changes proposed in this pull request:

  • Support setting whether SES includes original email headers in SNS notifications of the specified type (reference)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsSESIdentityNotificationTopic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsSESIdentityNotificationTopic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsSESIdentityNotificationTopic_basic
=== PAUSE TestAccAwsSESIdentityNotificationTopic_basic
=== CONT  TestAccAwsSESIdentityNotificationTopic_basic
--- PASS: TestAccAwsSESIdentityNotificationTopic_basic (25.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       25.046s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 24, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 25, 2019
@neilbartley
Copy link
Contributor

@vaskevich would you have the time to update this? If not please yell and I'll get my merge boots on :)

@oleg-codaio oleg-codaio force-pushed the osv-include-original-headers branch from 10e457f to 5db3465 Compare April 29, 2019 17:43
@oleg-codaio
Copy link
Contributor Author

Sure, updated.

@neilbartley
Copy link
Contributor

Thanks @vaskevich.

Hopefully, this will get merged soon and cut out the only manual step in my proccess ⛏

@mtmn
Copy link

mtmn commented Jun 6, 2019

Any updates on this?

@oleg-codaio
Copy link
Contributor Author

It's ready to go on my end. Just need a maintainer to review and merge.

@bflad bflad added this to the v2.15.0 milestone Jun 10, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vaskevich 👋 Sorry for the delay in getting this reviewed. This looks good to me! 🚀

Output from acceptance testing:

--- PASS: TestAccAwsSESIdentityNotificationTopic_basic (17.70s)

@bflad bflad merged commit 9a2d0f4 into hashicorp:master Jun 10, 2019
pull bot pushed a commit to KernelPanicAUS/terraform-provider-aws that referenced this pull request Jun 10, 2019
@oleg-codaio oleg-codaio deleted the osv-include-original-headers branch June 11, 2019 20:41
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ability to request headers with ses_identity_notification_topic
4 participants