Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR Cluster Flatten Instance Group Name #7324

Merged
merged 1 commit into from
Jan 25, 2019
Merged

EMR Cluster Flatten Instance Group Name #7324

merged 1 commit into from
Jan 25, 2019

Conversation

mbfrahry
Copy link
Member

This PR addresses #7278 and was caused by not flattening the name with the instance group Set.

Pre fix

--- FAIL: TestAccAWSEMRCluster_instance_group_name (433.90s)

Post Fix

--- PASS: TestAccAWSEMRCluster_security_config (449.25s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (533.29s)
--- PASS: TestAccAWSEMRCluster_instance_group (546.73s)
--- PASS: TestAccAWSEMRCluster_instance_group_update (548.66s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (558.77s)
--- PASS: TestAccAWSEMRCluster_basic (567.99s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (588.08s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (588.83s)
--- PASS: TestAccAWSEMRCluster_instance_group_EBSVolumeType_st1 (616.62s)
--- PASS: TestAccAWSEMRCluster_updateAutoScalingPolicy (620.66s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (620.73s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (625.99s)
--- PASS: TestAccAWSEMRCluster_instance_group_name (638.32s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (639.06s)
--- PASS: TestAccAWSEMRCluster_keepJob (641.59s)
--- PASS: TestAccAWSEMRCluster_s3Logging (652.75s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (663.43s)
--- PASS: TestAccAWSEMRCluster_tags (794.90s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (998.26s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (1043.95s)

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 25, 2019
@mbfrahry mbfrahry requested a review from a team January 25, 2019 02:10
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added this to the v1.57.0 milestone Jan 25, 2019
@mbfrahry mbfrahry merged commit 78c6ea3 into master Jan 25, 2019
@mbfrahry mbfrahry deleted the b-emr-cluster-ig branch January 25, 2019 02:25
bflad added a commit that referenced this pull request Jan 25, 2019
@bflad
Copy link
Contributor

bflad commented Jan 26, 2019

This has been released in version 1.57.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants