Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7351: aws_ssm_resource_data_sync - doesn't support update #7490

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

saravanan30erd
Copy link
Contributor

Fixes #7351

Changes proposed in this pull request:

  • Change 1
    updated resource schema to recreate the resource

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSsmResourceDataSync_update'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSSsmResourceDataSync_update -timeout 120m
=== RUN   TestAccAWSSsmResourceDataSync_update
=== PAUSE TestAccAWSSsmResourceDataSync_update
=== CONT  TestAccAWSSsmResourceDataSync_update
--- PASS: TestAccAWSSsmResourceDataSync_update (161.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	161.274s
...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 9, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Feb 12, 2019
@bflad bflad added this to the v1.59.0 milestone Feb 12, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @saravanan30erd! 🚀

Previous output from acceptance testing:

--- FAIL: TestAccAWSSsmResourceDataSync_update (46.56s)
    testing.go:538: Step 1 error: Error applying: 1 error occurred:
        	* aws_ssm_resource_data_sync.foo: 1 error occurred:
        	* aws_ssm_resource_data_sync.foo: doesn't support update

Output from acceptance testing:

--- PASS: TestAccAWSSsmResourceDataSync_basic (6.26s)
--- PASS: TestAccAWSSsmResourceDataSync_import (6.79s)
--- PASS: TestAccAWSSsmResourceDataSync_update (12.01s)

@bflad bflad merged commit f11c494 into hashicorp:master Feb 12, 2019
bflad added a commit that referenced this pull request Feb 12, 2019
bflad added a commit that referenced this pull request Feb 12, 2019
@saravanan30erd saravanan30erd deleted the issue-7351 branch February 14, 2019 23:48
@bflad
Copy link
Contributor

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ssm_resource_data_sync - doesn't support update
2 participants