Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_iam_role: Remove deprecated attributes #7696

Merged
merged 1 commit into from
Feb 27, 2019
Merged

data-source/aws_iam_role: Remove deprecated attributes #7696

merged 1 commit into from
Feb 27, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 24, 2019

Closes #7675

Changes:

  • Remove deprecated assume_role_policy_document attribute
  • Remove deprecated role_id attribute
  • Remove deprecated role_name argument
  • Change name from optional to required
  • Return context for all errors
  • Document missing attributes

Output from acceptance testing:

--- PASS: TestAccAWSDataSourceIAMRole_basic (10.60s)

@bflad
data-source/aws_iam_role: Remove deprecated attributes
f565103 
Reference: #7675

Changes:

* Remove deprecated `assume_role_policy_document` attribute
* Remove deprecated `role_id` attribute
* Remove deprecated `role_name` argument
* Change `name` from optional to required
* Return context for all errors
* Document missing attributes

Output from acceptance testing:

```
--- PASS: TestAccAWSDataSourceIAMRole_basic (10.60s)
```
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/iam Issues and PRs that pertain to the iam service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 24, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 24, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 24, 2019
@bflad bflad mentioned this pull request Feb 24, 2019
Closed
@bflad bflad requested a review from a team February 26, 2019 15:42
@bflad bflad merged commit a5c1030 into master Feb 27, 2019
@bflad bflad deleted the td-aws_iam_role-remove-deprecated branch February 27, 2019 00:40
bflad added a commit that referenced this pull request Feb 27, 2019
@bflad
Update CHANGELOG for #7696
6d15afa
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.0.0
2 participants
@bflad @paultyng