Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_guardduty_detector: Clarify finding_publishing_frequency usage for member accounts #7804

Merged
merged 2 commits into from
Mar 4, 2019
Merged

resource/aws_guardduty_detector: Clarify finding_publishing_frequency usage for member accounts #7804

merged 2 commits into from
Mar 4, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 4, 2019

Closes #7781

Output from acceptance testing:

    --- PASS: TestAccAWSGuardDuty/Detector (36.21s)
        --- PASS: TestAccAWSGuardDuty/Detector/basic (25.70s)
        --- PASS: TestAccAWSGuardDuty/Detector/import (10.50s)

@bflad
resource/aws_guardduty_detector: Clarify finding_publishing_frequency…
1db9645 
… usage for member accounts

Reference:
* #7781

Output from acceptance testing:

```
    --- PASS: TestAccAWSGuardDuty/Detector (36.21s)
        --- PASS: TestAccAWSGuardDuty/Detector/basic (25.70s)
        --- PASS: TestAccAWSGuardDuty/Detector/import (10.50s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/guardduty Issues and PRs that pertain to the guardduty service. labels Mar 4, 2019
@bflad bflad requested a review from a team March 4, 2019 17:35
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Mar 4, 2019
@bflad bflad mentioned this pull request Mar 4, 2019
Closed
nywilken
nywilken approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation needs to be clarified a bit, but this is otherwise good. I am approving so that you can merge once you are happy with the documentation.

website/docs/r/guardduty_detector.html.markdown Outdated
@@ -26,7 +25,7 @@ resource "aws_guardduty_detector" "MyDetector" {
The following arguments are supported:

* `enable` - (Optional) Enable monitoring and feedback reporting. Setting to `false` is equivalent to "suspending" GuardDuty. Defaults to `true`.
* `finding_publishing_frequency` - (Optional) Specifies the frequency of notifications sent for subsequent finding occurrences. Valid values: `FIFTEEN_MINUTES, ONE_HOUR, SIX_HOURS`. Default: `SIX_HOURS`. See [AWS Documentation](https://docs.aws.amazon.com/guardduty/latest/ug/guardduty_findings_cloudwatch.html#guardduty_findings_cloudwatch_notification_frequency) for more information.
* `finding_publishing_frequency` - (Optional) Specifies the frequency of notifications sent for subsequent finding occurrences. Cannot be modified for GuardDuty member accounts. Must be configured to enable drift detection in GuardDuty master accounts. Valid values: `FIFTEEN_MINUTES`, `ONE_HOUR`, `SIX_HOURS`. Default: `SIX_HOURS` for GuardDuty master account or matches GuardDuty master account if GuardDuty member account. See [AWS Documentation](https://docs.aws.amazon.com/guardduty/latest/ug/guardduty_findings_cloudwatch.html#guardduty_findings_cloudwatch_notification_frequency) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid values: FIFTEEN_MINUTES, ONE_HOUR, SIX_HOURS. Default: SIX_HOURS for GuardDuty master account or matches GuardDuty master account if GuardDuty member account.

I'm not sure what you are tying to say here. Is this supposed to say something along the lines of GuardDuty member account will match the frequency value defined in the master account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll try to clarify the wording a little better. 👍

@bflad bflad added this to the v2.1.0 milestone Mar 4, 2019
@bflad bflad merged commit 4047689 into master Mar 4, 2019
@bflad bflad deleted the b-aws_guardduty_detector-member-publishing branch March 4, 2019 23:03
bflad added a commit that referenced this pull request Mar 4, 2019
@bflad
Update CHANGELOG for #7804
8308841
@bflad
Copy link
Contributor Author

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/guardduty Issues and PRs that pertain to the guardduty service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

aws_guardduty_detector attempts to modify settings when account is a member (vs master)
2 participants
@bflad @nywilken