-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ComplianceSeverity Argument #7852
Added ComplianceSeverity Argument #7852
Conversation
Signed-off-by: Marco Tesch <mtesch@tecracer.de>
Hi @marcotesch 👋 Thanks for contributing this, its looking pretty good so far. Can you please add a new acceptance test in |
Hi @bflad , I tried to understand the acceptance test layout as you use it, hope I have done everything right 🙈 . make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMAssociation_withComplianceSeverity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSSMAssociation_withComplianceSeverity -timeout 120m
=== RUN TestAccAWSSSMAssociation_withComplianceSeverity
=== PAUSE TestAccAWSSSMAssociation_withComplianceSeverity
=== CONT TestAccAWSSSMAssociation_withComplianceSeverity
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (19.02s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 19.066s |
Signed-off-by: Marco Tesch <mtesch@tecracer.de>
Critical Severity added as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @marcotesch! 🚀
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (19.27s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (28.60s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (34.14s)
--- PASS: TestAccAWSSSMAssociation_withParameters (36.16s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (36.17s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (36.17s)
--- PASS: TestAccAWSSSMAssociation_withTargets (39.26s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (67.86s)
--- PASS: TestAccAWSSSMAssociation_basic (149.51s)
This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Signed-off-by: Marco Tesch mtesch@tecracer.de
Community Note
Changes proposed in this pull request: