Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticache: Retry deletion of param grp on InvalidCacheParameterGroupState #8

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

radeksimko
Copy link
Member

This is to address the following test failure:

=== RUN   TestAccAWSElasticacheParameterGroup_importBasic
--- FAIL: TestAccAWSElasticacheParameterGroup_importBasic (6.98s)
    testing.go:492: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_elasticache_parameter_group.bar (destroy): 1 error(s) occurred:
        
        * aws_elasticache_parameter_group.bar: InvalidCacheParameterGroupState: Cache parameter group parameter-group-test-terraform-620255685172994862 can not be deleted in the current state.
            status code: 400, request id: 1bb9eeba-4cd3-11e7-8b4a-e9587f270628
        
        State: aws_elasticache_parameter_group.bar:
          ID = parameter-group-test-terraform-620255685172994862
          description = Managed by Terraform
          family = redis2.8
          name = parameter-group-test-terraform-620255685172994862
          parameter.# = 1
          parameter.283487565.name = appendonly
          parameter.283487565.value = yes

Test results

$ make testacc TESTARGS='-run=TestAccAWSElasticacheParameterGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSElasticacheParameterGroup -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSElasticacheParameterGroup_importBasic
--- PASS: TestAccAWSElasticacheParameterGroup_importBasic (31.20s)
=== RUN   TestAccAWSElasticacheParameterGroup_basic
--- PASS: TestAccAWSElasticacheParameterGroup_basic (51.81s)
=== RUN   TestAccAWSElasticacheParameterGroupOnly
--- PASS: TestAccAWSElasticacheParameterGroupOnly (28.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	111.192s

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jun 11, 2017
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 12abeb2 into master Jun 12, 2017
@radeksimko radeksimko deleted the b-aws-retry-invalid-state branch June 12, 2017 09:05
gdavison pushed a commit that referenced this pull request Nov 16, 2019
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants