Bugfix: allow updates to metric_query on aws_cloudwatch_metric_alarm

[sjauld]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7593

Changes proposed in this pull request:

• allow updates to metric_query on aws_cloudwatch_metric_alarm

Output from acceptance testing:

aws-vault exec sand-superuser -- make testacc TESTARGS="-run TestAccAWSCloudWatchMetricAlarm"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAWSCloudWatchMetricAlarm -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_basic
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== RUN   TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== PAUSE TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== RUN   TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccAWSCloudWatchMetricAlarm_expression
=== PAUSE TestAccAWSCloudWatchMetricAlarm_expression
=== RUN   TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_basic
=== CONT  TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== CONT  TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== CONT  TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== CONT  TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== CONT  TestAccAWSCloudWatchMetricAlarm_expression
=== CONT  TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (10.63s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (33.01s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (33.07s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (37.68s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (41.93s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (42.46s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (55.71s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (56.70s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (113.50s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (360.05s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       360.108s

Please see ad064a6 for the output of the failing test prior to this patch.

[bflad]

Thanks so much for the fix and testing update, @sjauld! I can confirm the test change adequately covers the problem mentioned in the issue. 🚀

Prior to code change:

--- FAIL: TestAccAWSCloudWatchMetricAlarm_expression (30.16s)
    testing.go:538: Step 4 error: Error applying: 1 error occurred:
        	* aws_cloudwatch_metric_alarm.foobar: 1 error occurred:
        	* aws_cloudwatch_metric_alarm.foobar: Updating metric alarm failed: InvalidParameter: 1 validation error(s) found.
        - minimum field size of 1, PutMetricAlarmInput.Metrics[2].Id.

Output from acceptance testing:

--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (4.92s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (11.65s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (11.74s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (12.72s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (13.57s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (15.23s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (17.74s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (18.06s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (34.04s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (173.47s)

[bflad]

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!