Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Private Link setting for AWS Tranfer for SFTP Service #8121

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8105

Changes proposed in this pull request:

  • Add Private Link Support for AWS Transfer service.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransferServer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSTransferServer_ -timeout 120m
=== RUN   TestAccAWSTransferServer_basic
=== PAUSE TestAccAWSTransferServer_basic
=== RUN   TestAccAWSTransferServer_apigateway
=== PAUSE TestAccAWSTransferServer_apigateway
=== RUN   TestAccAWSTransferServer_disappears
=== PAUSE TestAccAWSTransferServer_disappears
=== RUN   TestAccAWSTransferServer_forcedestroy
=== PAUSE TestAccAWSTransferServer_forcedestroy
=== RUN   TestAccAWSTransferServer_vpcEndpointId
=== PAUSE TestAccAWSTransferServer_vpcEndpointId
=== CONT  TestAccAWSTransferServer_basic
=== CONT  TestAccAWSTransferServer_forcedestroy
=== CONT  TestAccAWSTransferServer_vpcEndpointId
=== CONT  TestAccAWSTransferServer_disappears
=== CONT  TestAccAWSTransferServer_apigateway
--- PASS: TestAccAWSTransferServer_disappears (24.45s)
--- PASS: TestAccAWSTransferServer_forcedestroy (40.59s)
--- PASS: TestAccAWSTransferServer_apigateway (41.64s)
--- PASS: TestAccAWSTransferServer_basic (58.41s)
--- PASS: TestAccAWSTransferServer_vpcEndpointId (80.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	80.376s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 29, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. labels Apr 5, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSTransferServer_disappears (5.83s)
--- PASS: TestAccAWSTransferServer_apigateway (10.05s)
--- PASS: TestAccAWSTransferServer_forcedestroy (11.05s)
--- PASS: TestAccAWSTransferServer_basic (15.48s)
--- PASS: TestAccAWSTransferServer_vpcEndpointId (32.34s)

"vpc_endpoint_id": {
Type: schema.TypeString,
Required: true,
ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This can be simplified with the below but certainly not worth holding up this pull request for:

ValidateFunc: validation.StringMatch(regexp.MustCompile(`^vpce-[0-9a-f]{17}$`), "must match VPC Endpoint identifier beginning with vpce-"),

@bflad bflad added this to the v2.6.0 milestone Apr 10, 2019
@bflad bflad merged commit 4b1a3fd into hashicorp:master Apr 10, 2019
bflad added a commit that referenced this pull request Apr 10, 2019
@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-support-privatelink-for-transfer-server branch March 5, 2020 14:03
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Transfer for SFTP service PrivateLink support
2 participants