-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support Private Link setting for AWS Tranfer for SFTP Service #8121
Add support Private Link setting for AWS Tranfer for SFTP Service #8121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kterada0509 🚀
--- PASS: TestAccAWSTransferServer_disappears (5.83s)
--- PASS: TestAccAWSTransferServer_apigateway (10.05s)
--- PASS: TestAccAWSTransferServer_forcedestroy (11.05s)
--- PASS: TestAccAWSTransferServer_basic (15.48s)
--- PASS: TestAccAWSTransferServer_vpcEndpointId (32.34s)
"vpc_endpoint_id": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This can be simplified with the below but certainly not worth holding up this pull request for:
ValidateFunc: validation.StringMatch(regexp.MustCompile(`^vpce-[0-9a-f]{17}$`), "must match VPC Endpoint identifier beginning with vpce-"),
This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8105
Changes proposed in this pull request:
Output from acceptance testing: