Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_lb_target_group: Add missing schema attributes #8213

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8209.

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAWSALBTargetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAWSALBTargetGroup_ -timeout 120m
=== RUN   TestAccDataSourceAWSALBTargetGroup_basic
=== PAUSE TestAccDataSourceAWSALBTargetGroup_basic
=== CONT  TestAccDataSourceAWSALBTargetGroup_basic
--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (194.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	194.348s

See #8209 (comment) for how the same test was failing before this PR.

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Apr 5, 2019
@ewbankkit
Copy link
Contributor Author

The proxy_protocol_v2 and target_type attributes were also missing from the data source but since d.Set() return value isn't usually checked for "simple" attribute types, no errors were returned.
The documentation says:

See the LB Target Group Resource for details on the returned attributes - they are identical.

The name_prefix attribute isn't returned as it is not applicable to the data source.

"lambda_multi_value_headers_enabled": {
Type: schema.TypeBool,
Computed: true,
},

"slow_start": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ordered some attributes to match the order in the resource definition.

@bflad bflad added the bug Addresses a defect in current functionality. label Apr 5, 2019
@bflad bflad added this to the v2.6.0 milestone Apr 5, 2019
@bflad bflad added the regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. label Apr 5, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @ewbankkit 🚀

--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (296.14s)

@bflad bflad merged commit 18fd544 into hashicorp:master Apr 6, 2019
bflad added a commit that referenced this pull request Apr 6, 2019
@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit deleted the issue-8209 branch April 16, 2019 13:15
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error setting health_check with AWS 2.5.0 when performing a target_group data lookup
2 participants