Use tag-on-create for sfn

[jukie]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7671

Changes proposed in this pull request:

• Set tags at creation time

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnActivity_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSfnActivity_Tags -timeout 120m
=== RUN   TestAccAWSSfnActivity_Tags
=== PAUSE TestAccAWSSfnActivity_Tags
=== CONT  TestAccAWSSfnActivity_Tags
--- PASS: TestAccAWSSfnActivity_Tags (23.25s)
PASS
ok  	github.com/jukie/terraform-provider-aws/aws	23.303s

...

[bflad]

Looks good, @jukie, thanks! 🚀

Output from AWS Standard acceptance testing (failure unrelated):

--- PASS: TestAccAWSSfnActivity_basic (13.20s)
--- PASS: TestAccAWSSfnActivity_importBasic (14.40s)
--- PASS: TestAccAWSSfnActivity_Tags (31.89s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (36.66s)
    testing.go:568: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:187416307283:function:sfn-qqccgc0m48\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- PASS: TestAccAWSSfnStateMachine_Tags (50.20s)

Output from AWS GovCloud (US) acceptance testing (failure unrelated and after another quick test fix which I'll submit after this):

--- PASS: TestAccAWSSfnActivity_basic (17.29s)
--- PASS: TestAccAWSSfnActivity_importBasic (19.04s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (41.69s)
    testing.go:568: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws-us-gov:lambda:us-gov-west-1:357342307427:function:sfn-18y92jitjb\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- PASS: TestAccAWSSfnActivity_Tags (59.11s)
--- PASS: TestAccAWSSfnStateMachine_Tags (62.98s)

[bflad]

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!