Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds roots attribute to the aws_organizations_organization resource #8399

Merged

Conversation

bryanlalexander
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

As mentioned in #4207 @bflad requested the modification of the aws_organizations_organization resource to contain the response from organizations:ListRoots. This will resolve the dependency on a data source when creating an organizations_organizational_unit mentioned in #4207.

Changes proposed in this pull request:

  • adds the response from calling organizations:ListRoots to the aws_organizations_organization resource
  • updates attribute documentation on website

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSOrganizations'

=== RUN   TestAccAWSOrganizations
=== RUN   TestAccAWSOrganizations/Organization
=== RUN   TestAccAWSOrganizations/Organization/basic
=== RUN   TestAccAWSOrganizations/Organization/importBasic
=== RUN   TestAccAWSOrganizations/Organization/consolidatedBilling
=== RUN   TestAccAWSOrganizations/Account
=== RUN   TestAccAWSOrganizations/Account/basic
--- PASS: TestAccAWSOrganizations (61.00s)
    --- PASS: TestAccAWSOrganizations/Organization (60.99s)
        --- PASS: TestAccAWSOrganizations/Organization/basic (19.64s)
        --- PASS: TestAccAWSOrganizations/Organization/importBasic (22.88s)
        --- PASS: TestAccAWSOrganizations/Organization/consolidatedBilling (18.46s)
    --- PASS: TestAccAWSOrganizations/Account (0.00s)
        --- SKIP: TestAccAWSOrganizations/Account/basic (0.00s)
            resource_aws_organizations_account_test.go:20: 'TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN' not set, skipping test.
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       61.288s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/organizations Issues and PRs that pertain to the organizations service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 21, 2019
@bryanlalexander bryanlalexander changed the title [WIP] adds roots attribute to the aws_organizations_organization resource adds roots attribute to the aws_organizations_organization resource Apr 21, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bryanlalexander 👋 Thanks so much for submitting this. Its off to a great start. I left a few minor feedback items below -- if you can address those we can get this merged in. Please reach out if you have any questions or do not have time to address them.

aws/resource_aws_organizations_organization.go Outdated Show resolved Hide resolved
aws/resource_aws_organizations_organization.go Outdated Show resolved Hide resolved
aws/structure.go Outdated Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels May 6, 2019
…zationsOrganizationRead

Co-Authored-By: bryanlalexander <bryan.alexander@gsa.gov>
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 6, 2019
@bryanlalexander
Copy link
Contributor Author

Thanks for taking a look @bflad, got those addressed.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label May 6, 2019
@bflad bflad added this to the v2.10.0 milestone May 6, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bryanlalexander! 🚀

Output from acceptance testing:

    --- PASS: TestAccAWSOrganizations/Organization (90.91s)
        --- PASS: TestAccAWSOrganizations/Organization/basic (22.76s)
        --- PASS: TestAccAWSOrganizations/Organization/AwsServiceAccessPrincipals (45.54s)
        --- PASS: TestAccAWSOrganizations/Organization/FeatureSet (22.61s)

@bflad bflad merged commit 466835e into hashicorp:master May 6, 2019
bflad added a commit that referenced this pull request May 6, 2019
@bflad
Copy link
Contributor

bflad commented May 10, 2019

This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants