-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds roots attribute to the aws_organizations_organization resource #8399
adds roots attribute to the aws_organizations_organization resource #8399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bryanlalexander 👋 Thanks so much for submitting this. Its off to a great start. I left a few minor feedback items below -- if you can address those we can get this merged in. Please reach out if you have any questions or do not have time to address them.
…zationsOrganizationRead Co-Authored-By: bryanlalexander <bryan.alexander@gsa.gov>
Thanks for taking a look @bflad, got those addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bryanlalexander! 🚀
Output from acceptance testing:
--- PASS: TestAccAWSOrganizations/Organization (90.91s)
--- PASS: TestAccAWSOrganizations/Organization/basic (22.76s)
--- PASS: TestAccAWSOrganizations/Organization/AwsServiceAccessPrincipals (45.54s)
--- PASS: TestAccAWSOrganizations/Organization/FeatureSet (22.61s)
This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
As mentioned in #4207 @bflad requested the modification of the
aws_organizations_organization
resource to contain the response fromorganizations:ListRoots
. This will resolve the dependency on a data source when creating anorganizations_organizational_unit
mentioned in #4207.Changes proposed in this pull request:
organizations:ListRoots
to theaws_organizations_organization
resourceOutput from acceptance testing: