Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_db_instance_role_association #8466

Merged
merged 1 commit into from
May 1, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 27, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8038

Changes proposed in this pull request:

  • New Resource: aws_db_instance_role_association

Output from acceptance testing:

--- PASS: TestAccAWSDbInstanceRoleAssociation_basic (561.71s)
--- PASS: TestAccAWSDbInstanceRoleAssociation_disappears (675.31s)

@bflad bflad added new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service. labels Apr 27, 2019
@bflad bflad requested a review from a team April 27, 2019 03:53
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 27, 2019
Reference: #8038

Output from acceptance testing:

```
--- PASS: TestAccAWSDbInstanceRoleAssociation_basic (561.71s)
--- PASS: TestAccAWSDbInstanceRoleAssociation_disappears (675.31s)
```
@bflad bflad force-pushed the f-aws_db_instance_role_association branch from 7eb4c98 to b05c213 Compare April 27, 2019 04:04
@nywilken nywilken added this to the v2.9.0 milestone May 1, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken merged commit 74a1785 into master May 1, 2019
nywilken added a commit that referenced this pull request May 1, 2019
@bflad bflad deleted the f-aws_db_instance_role_association branch May 8, 2019 12:17
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Attaching and Detaching IAM Roles to RDS Database Instances (e.g. Oracle S3 Integration)
2 participants