Add support for advanced SSM parameters

[davidcelis]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_ssm_parameter: Add `tier` argument [GH-8525]

[bflad]

Hi @davidcelis 👋 Thanks for contributing this! Its off to a good start -- a few testing things and it should be good to go. Please reach out with any questions or if you do not have time to implement the feedback.

[bflad]

Hey @davidcelis, thanks for the updates here! When testing this for merging I swapped out the testing to also perform updates for the tier argument similar to #8525 (comment) and discovered that updating from Advanced to Standard returned the following API error:

--- FAIL: TestAccAWSSSMParameter_Tier (25.65s)
    testing.go:568: Step 1 error: errors during apply:

        Error: error creating SSM parameter: ValidationException: This parameter uses the advanced-parameter tier. You can't downgrade a parameter from the advanced-parameter tier to the standard-parameter tier. If necessary, you can delete the advanced parameter and recreate it as a standard parameter. Be aware that standard parameters have a value limit of 4096 characters.
        	status code: 400, request id: 8ffb05d8-5977-4226-8ef5-276b5be1fece

So! Turns out this needed some extra love for that specific scenario and in this case a relatively safe and simple CustomizeDiff only trigger resource recreation for this particular issue:

		CustomizeDiff: customdiff.All(
			// Prevent the following error during tier update from Advanced to Standard:
			// ValidationException: This parameter uses the advanced-parameter tier. You can't downgrade a parameter from the advanced-parameter tier to the standard-parameter tier. If necessary, you can delete the advanced parameter and recreate it as a standard parameter.
			customdiff.ForceNewIfChange("tier", func(old, new, meta interface{}) bool {
				return old.(string) == ssm.ParameterTierAdvanced && new.(string) == ssm.ParameterTierStandard
			}),
		),

With this in place, everything looks good. 🚀 Thanks so much for your contribution here! Should be able to get this released today. 👍

Output from acceptance testing after above changes:

--- PASS: TestAccAWSSSMParameter_disappears (9.99s)
--- PASS: TestAccAWSSSMParameter_basic (13.47s)
--- PASS: TestAccAWSSSMParameter_secure (13.74s)
--- PASS: TestAccAWSSSMParameter_fullPath (19.63s)
--- PASS: TestAccAWSSSMParameter_importBasic (21.78s)
--- PASS: TestAccAWSSSMParameter_updateTags (26.12s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (30.26s)
--- PASS: TestAccAWSSSMParameter_overwrite (32.02s)
--- PASS: TestAccAWSSSMParameter_updateDescription (35.51s)
--- PASS: TestAccAWSSSMParameter_Tier (37.83s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (46.98s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (61.83s)

[davidcelis]

oh wow, thank you for helping me bring this across the finish line, @bflad!!

[bflad]

This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[marpada]

@davidcelis thank you for being awesome!

[smolse]

Hi guys. I'm afraid this pull request breaks SSM parameters management in AWS China. Please check #8662.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!