New resource: aws_ec2_transit_gateway_vpc_attachment_accepter #8679

ewbankkit · 2019-05-17T22:06:16Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_ec2_transit_gateway_vpc_attachment_accepter (#8125)

Acceptance tests:

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=estAccAWSEc2TransitGatewayVpcAttachmentAccepter_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=estAccAWSEc2TransitGatewayVpcAttachmentAccepter_ -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (400.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	400.206s

aws/resource_aws_ec2_transit_gateway_vpc_attachment.go

website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown

ewbankkit · 2019-05-19T21:58:15Z

Removed WIP. Ready for review.

ewbankkit · 2019-05-19T22:30:36Z

I didn't add transit_gateway_default_route_table_association or transit_gateway_default_route_table_propagation attributes to this resource because of the notes in the documentation:

This cannot be configured or perform drift detection with Resource Access Manager shared EC2 Transit Gateways.

but maybe this resource, since it runs in the context of the AWS account that owns the transit gateway, is exactly where these attributes should be specified in the cross-account case?

Back to WIP until this is investigated.

Verified that these attributes can be modified on the accepter's side via this resource, so I'll add an acceptance test around that.

…teway_default_route_table_propagation' attributes.

…c-attachment'.

…ceptance test.

ewbankkit · 2019-05-22T12:14:34Z

Removed WIP.

Acceptance tests:

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_ -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (366.19s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (555.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	555.436s

bflad

Hey @ewbankkit 👋 Overall looking pretty good. The big item here being that resource's (even accepters) should implement the Delete function to ensure either side can remove attachments. Thanks!

bflad · 2019-05-24T13:18:31Z

aws/resource_aws_ec2_transit_gateway_vpc_attachment_accepter.go

+}
+
+func resourceAwsEc2TransitGatewayVpcAttachmentAccepterDelete(d *schema.ResourceData, meta interface{}) error {
+	log.Printf("[WARN] Will not delete EC2 Transit Gateway VPC Attachment. Terraform will remove this resource from the state file, however resources may remain.")


The accepting side should be able to call DeleteTransitGatewayVpcAttachment here to break the attachment. 👍

bflad · 2019-05-24T13:21:05Z

aws/resource_aws_ec2_transit_gateway_vpc_attachment_accepter_test.go

+				),
+			},
+			{
+				Config: testAccAWSEc2TransitGatewayVpcAttachmentAccepterConfig_updated(rName),


The updated configuration here seems to be only modifying tags. We prefer the _basic tests to only check the required configuration for a resource (in this case, no tags) and creating a separate Tags test to check tags on create and update. 😄

bflad · 2019-05-24T13:26:43Z

website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown

+* `transit_gateway_default_route_table_propagation` - (Optional) Boolean whether the VPC Attachment should propagate routes with the EC2 Transit Gateway propagation default route table. Default value: `true`.
+* `tags` - (Optional) Key-value tags for the EC2 Transit Gateway VPC Attachment.
+
+### Removing `aws_ec2_transit_gateway_vpc_attachment_accepter` from your configuration


When the Delete function is implemented, this section of the resource documentation should be removed. If this restriction is actually necessary, please instead move it to a note at the top of the page:

~> **NOTE:** Deleting this resource only removes it from state management, etc.

ewbankkit · 2019-05-24T20:58:43Z

Review comments addressed.
Re-ran acceptance tests:

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 2 -run=TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_ -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (332.64s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (564.78s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (355.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	688.702s

bflad

Thanks so much for the update, @ewbankkit, looks great. 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (352.97s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (354.94s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (538.85s)

bflad · 2019-05-31T16:58:24Z

This has been released in version 2.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-03-29T17:54:17Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. documentation Introduces or discusses updates to documentation. labels May 17, 2019

ewbankkit force-pushed the issue-8125 branch from 7a1d6b0 to f2fdbb4 Compare May 18, 2019 22:18

ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/M Managed by automation to categorize the size of a PR. labels May 18, 2019

Add 'aws_ec2_transit_gateway_vpc_attachment_accepter' resource.

60ddf7c

ewbankkit force-pushed the issue-8125 branch from f2fdbb4 to 60ddf7c Compare May 19, 2019 21:54

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 19, 2019

ewbankkit changed the title ~~[WIP] New resource: aws_ec2_transit_gateway_vpc_attachment_accepter~~ New resource: aws_ec2_transit_gateway_vpc_attachment_accepter May 19, 2019

ewbankkit commented May 19, 2019

View reviewed changes

aws/resource_aws_ec2_transit_gateway_vpc_attachment.go Show resolved Hide resolved

ewbankkit commented May 19, 2019

View reviewed changes

aws/resource_aws_ec2_transit_gateway_vpc_attachment.go Show resolved Hide resolved

ewbankkit commented May 19, 2019

View reviewed changes

aws/resource_aws_ec2_transit_gateway_vpc_attachment.go Show resolved Hide resolved

ewbankkit commented May 19, 2019

View reviewed changes

website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown Show resolved Hide resolved

ewbankkit mentioned this pull request May 19, 2019

aws_ec2_transit_gateway_vpc_attachment does not set transit_gateway_default_route_table_association or transit_gateway_default_route_table_propagation correctly #8383

Closed

ewbankkit changed the title ~~New resource: aws_ec2_transit_gateway_vpc_attachment_accepter~~ [WIP] New resource: aws_ec2_transit_gateway_vpc_attachment_accepter May 20, 2019

Kit Ewbank added 3 commits May 20, 2019 15:42

Add 'transit_gateway_default_route_table_association' and 'transit_ga…

dea406a

…teway_default_route_table_propagation' attributes.

Add documentation links to 'examples/transit-gateway-cross-account-vp…

97904d4

…c-attachment'.

Add efault_route_table_association/default_route_table_propagation ac…

119e3c3

…ceptance test.

ewbankkit changed the title ~~[WIP] New resource: aws_ec2_transit_gateway_vpc_attachment_accepter~~ New resource: aws_ec2_transit_gateway_vpc_attachment_accepter May 22, 2019

bflad added the new-resource Introduces a new resource. label May 24, 2019

bflad reviewed May 24, 2019

View reviewed changes

ewbankkit added 2 commits May 24, 2019 16:31

Allow accepter to delete transit gateway VPC attachment.

469b6fe

Add a real '_basic' acceptance tests.

559675d

bflad added this to the v2.13.0 milestone May 27, 2019

bflad approved these changes May 27, 2019

View reviewed changes

bflad merged commit 014bf2e into hashicorp:master May 27, 2019

bflad added a commit that referenced this pull request May 27, 2019

Update CHANGELOG for #8679

0cf9230

ewbankkit deleted the issue-8125 branch May 28, 2019 11:34

ghost locked and limited conversation to collaborators Mar 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_ec2_transit_gateway_vpc_attachment_accepter #8679

New resource: aws_ec2_transit_gateway_vpc_attachment_accepter #8679

ewbankkit commented May 17, 2019 •

edited

Loading

ewbankkit commented May 19, 2019

ewbankkit commented May 19, 2019 •

edited

Loading

ewbankkit commented May 22, 2019

bflad left a comment

bflad May 24, 2019

bflad May 24, 2019

bflad May 24, 2019

ewbankkit commented May 24, 2019

bflad left a comment

bflad commented May 31, 2019

ghost commented Mar 29, 2020

New resource: aws_ec2_transit_gateway_vpc_attachment_accepter #8679

New resource: aws_ec2_transit_gateway_vpc_attachment_accepter #8679

Conversation

ewbankkit commented May 17, 2019 • edited Loading

Community Note

ewbankkit commented May 19, 2019

ewbankkit commented May 19, 2019 • edited Loading

ewbankkit commented May 22, 2019

bflad left a comment

Choose a reason for hiding this comment

bflad May 24, 2019

Choose a reason for hiding this comment

bflad May 24, 2019

Choose a reason for hiding this comment

bflad May 24, 2019

Choose a reason for hiding this comment

ewbankkit commented May 24, 2019

bflad left a comment

Choose a reason for hiding this comment

bflad commented May 31, 2019

ghost commented Mar 29, 2020

ewbankkit commented May 17, 2019 •

edited

Loading

ewbankkit commented May 19, 2019 •

edited

Loading