Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_msk_configuration #8740

Merged
merged 2 commits into from
May 23, 2019
Merged

New Resource: aws_msk_configuration #8740

merged 2 commits into from
May 23, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 22, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8736

Release note for CHANGELOG:

**New Resource:** `aws_msk_configuration`

Output from acceptance testing:

--- PASS: TestAccAWSMskConfiguration_KafkaVersions (14.14s)
--- PASS: TestAccAWSMskConfiguration_Description (19.35s)
--- PASS: TestAccAWSMskConfiguration_basic (27.64s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (29.51s)

Reference: #8736

Output from acceptance testing:

```
--- PASS: TestAccAWSMskConfiguration_KafkaVersions (14.14s)
--- PASS: TestAccAWSMskConfiguration_Description (19.35s)
--- PASS: TestAccAWSMskConfiguration_basic (27.64s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (29.51s)
```
@bflad bflad added new-resource Introduces a new resource. service/kafka Issues and PRs that pertain to the kafka service. labels May 22, 2019
@bflad bflad added this to the v2.12.0 milestone May 22, 2019
@bflad bflad requested a review from a team May 22, 2019 17:36
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 22, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight issue with the resource documentation, but otherwise good to go +1


~> **NOTE:** The API does not support deleting MSK configurations. Removing this Terraform resource will only remove the Terraform state for it.

~> **NOTE:** This AWS service is in Preview and may change before General Availability release. Backwards compatibility is not guaranteed between Terraform AWS Provider releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

website/docs/r/msk_configuration.html.markdown Outdated Show resolved Hide resolved
@nywilken nywilken self-assigned this May 23, 2019
Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>
@bflad bflad merged commit 5ed2ff5 into master May 23, 2019
@bflad bflad deleted the f-aws_msk_configuration branch May 23, 2019 11:07
bflad added a commit that referenced this pull request May 23, 2019
@bflad
Copy link
Contributor Author

bflad commented May 24, 2019

This has been released in version 2.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@paulca99
Copy link

paulca99 commented Jun 5, 2019

Hi Guys, I'm struggling here , how do I link an aws_msk_configuration to an aws_msk_cluster so that the cluster allows topics to be deleted ?

@bflad
Copy link
Contributor Author

bflad commented Jun 5, 2019

@paulca99 this requires the aws_msk_cluster updates that were just merged in as part of #8850 and will be released in version 2.14.0 of the Terraform AWS Provider likely tomorrow. e.g.

resource "aws_msk_configuration" "example" {
  kafka_versions = ["1.1.1"]
  name           = "example"

  server_properties = <<PROPERTIES
delete.topic.enable = true
PROPERTIES
}

resource "aws_msk_cluster" "example" {
  cluster_name           = "example"
  kafka_version          = "1.1.1"
  number_of_broker_nodes = 3

  broker_node_group_info {
    client_subnets  = ["${aws_subnet.example1.id}", "${aws_subnet.example2.id}", "${aws_subnet.example3.id}"]
    ebs_volume_size = 10
    instance_type   = "kafka.m5.large"
    security_groups = ["${aws_security_group.example.id}"]
  }

  configuration_info {
    arn      = "${aws_msk_configuration.example.arn}"
    revision = "${aws_msk_configuration.example.latest_revision}"
  }
}

@paulca99
Copy link

paulca99 commented Jun 6, 2019

Thanks @bflad

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafka Issues and PRs that pertain to the kafka service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for managing MSK Configurations
3 participants