Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_msk_cluster #8743

Merged
merged 2 commits into from
May 23, 2019
Merged

New Data Source: aws_msk_cluster #8743

merged 2 commits into from
May 23, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 22, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

**New Data Source:** `aws_msk_cluster`

Output from acceptance testing:

--- PASS: TestAccAWSMskClusterDataSource_Name (1057.30s)

@bflad bflad added new-data-source Introduces a new data source. service/kafka Issues and PRs that pertain to the kafka service. labels May 22, 2019
@bflad bflad added this to the v2.12.0 milestone May 22, 2019
@bflad bflad requested a review from a team May 22, 2019 19:02
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 22, 2019
@bflad
New Data Source: aws_msk_cluster
8f53289 
Output from acceptance testing:

```
--- PASS: TestAccAWSMskClusterDataSource_Name (1057.30s)
```
@bflad bflad force-pushed the f-aws_msk_cluster-datasource branch from a845127 to 8f53289 Compare May 22, 2019 20:10
@nywilken nywilken self-assigned this May 23, 2019
nywilken
nywilken approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight issue with the resource documentation, but otherwise good to go 👍

--- PASS: TestAccAWSMskClusterDataSource_Name (1059.13s)

website/docs/d/msk_cluster.html.markdown Outdated Show resolved Hide resolved
@bflad @nywilken
Update website/docs/d/msk_cluster.html.markdown
cbac001 
Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>
@bflad bflad merged commit ef56d5b into master May 23, 2019
@bflad bflad deleted the f-aws_msk_cluster-datasource branch May 23, 2019 11:09
bflad added a commit that referenced this pull request May 23, 2019
@bflad
Update CHANGELOG for #8743
e7edb6d
@bflad
Copy link
Contributor Author

bflad commented May 24, 2019

This has been released in version 2.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost unassigned nywilken Mar 29, 2020
@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafka Issues and PRs that pertain to the kafka service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken