Allow ipv6_cidr_block to be assigned to peering_connection

[martinssipenko]

I've encountered an issue when trying to use destination_ipv6_cidr_block with vpc_peering_connection_id. I believe this fixes #778.

I'm not sure about whether destination_ipv6_cidr_block should be allowed together with other types (nat_gateway_id, instance_id, network_interface_id).

Also, I could not find any acceptance test for this functionality, so I've not added any new tests to cover this. I'm happy to add tests, however I might need guidance.

This is a migrated pull request from original repo hashicorp/terraform#15145

[stack72]

Hi @martinssipenko

Thanks for migrating this PR from the other repo :) This LGTM!

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_basic (71.09s)
=== RUN   TestAccAWSRoute_ipv6Support
--- PASS: TestAccAWSRoute_ipv6Support (60.62s)
=== RUN   TestAccAWSRoute_ipv6ToInternetGateway
--- PASS: TestAccAWSRoute_ipv6ToInternetGateway (75.57s)
=== RUN   TestAccAWSRoute_ipv6ToPeeringConnection
--- PASS: TestAccAWSRoute_ipv6ToPeeringConnection (67.53s)
=== RUN   TestAccAWSRoute_changeCidr
--- PASS: TestAccAWSRoute_changeCidr (115.30s)
=== RUN   TestAccAWSRoute_noopdiff
--- PASS: TestAccAWSRoute_noopdiff (181.15s)
=== RUN   TestAccAWSRoute_doesNotCrashWithVPCEndpoint
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (77.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	648.513s

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!