Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/resource_aws_iot_role_alias: Add arn to the IoT role alias resource #8812

Merged
merged 3 commits into from
May 30, 2019
Merged

aws/resource_aws_iot_role_alias: Add arn to the IoT role alias resource #8812

merged 3 commits into from
May 30, 2019

Conversation

jhosteny
Copy link
Contributor

@jhosteny jhosteny commented May 29, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8811

Release note for CHANGELOG:

resource/aws_iot_role_alias: Add `arn` attribute (#8811)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIotRoleAlias_basic'
make testacc TESTARGS='-run=TestAccAWSIotRoleAlias_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSIotRoleAlias_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSIotRoleAlias_basic
=== PAUSE TestAccAWSIotRoleAlias_basic
=== CONT  TestAccAWSIotRoleAlias_basic
--- PASS: TestAccAWSIotRoleAlias_basic (89.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	89.370s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. labels May 29, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label May 29, 2019
@bflad
Copy link
Contributor

bflad commented May 29, 2019

Hi @jhosteny 👋 Thanks for contributing this! If you haven't seen the Contributing Guide section on adding an enhancement to a resource, we would recommend checking it out.

In this case, we will need two additional items before this can be merged:

  • Adding documentation for the new attribute in website/docs/r/iot_role_alias.html.markdown in the Attributes section, e.g.
* `arn` - Amazon Resource Name (ARN) of the IOT Role Alias
  • Adding covering acceptance testing for the new attribute in aws/resource_aws_iot_role_alias_test.go in TestAccAWSIotRoleAlias_basic under the first TestStep Check, e.g. something like the below (I couldn't find the exact ARN format in the Amazon Resource Names documentation)
testAccCheckResourceAttrRegionalARN("aws_iot_role_alias.ra", "arn", "iot", fmt.Sprintf("alias/%s", alias)),

Please reach out if you have any questions!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 29, 2019
@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 29, 2019
@jhosteny
Copy link
Contributor Author

@bflad thanks, I've added the missing docs and test

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label May 29, 2019
@bflad bflad added this to the v2.13.0 milestone May 30, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @jhosteny, looks good. 🚀

Output from acceptance testing:

--- PASS: TestAccAWSIotRoleAlias_basic (44.95s)

@bflad bflad merged commit 5ca2353 into hashicorp:master May 30, 2019
bflad added a commit that referenced this pull request May 30, 2019
@bflad
Copy link
Contributor

bflad commented May 31, 2019

This has been released in version 2.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arn to the IoT role alias
2 participants