-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws/resource_aws_iot_role_alias: Add arn to the IoT role alias resource #8812
aws/resource_aws_iot_role_alias: Add arn to the IoT role alias resource #8812
Conversation
Hi @jhosteny 👋 Thanks for contributing this! If you haven't seen the Contributing Guide section on adding an enhancement to a resource, we would recommend checking it out. In this case, we will need two additional items before this can be merged:
* `arn` - Amazon Resource Name (ARN) of the IOT Role Alias
testAccCheckResourceAttrRegionalARN("aws_iot_role_alias.ra", "arn", "iot", fmt.Sprintf("alias/%s", alias)), Please reach out if you have any questions! |
@bflad thanks, I've added the missing docs and test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @jhosteny, looks good. 🚀
Output from acceptance testing:
--- PASS: TestAccAWSIotRoleAlias_basic (44.95s)
This has been released in version 2.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8811
Release note for CHANGELOG:
Output from acceptance testing: