-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/s3_bucket: Support lifecycle tags filter #899
resource/s3_bucket: Support lifecycle tags filter #899
Conversation
+1 Would love to see this merged. |
Leaving this outstanding has been holding us up for months, we have to do targeted runs to avoid effecting our lifecycle rules on a managed s3 bucket. |
+1, would also love to see this merged. Not having this is blocking our adoption of terraform. |
Hi @kjmkznr |
aeaf81e
to
3a38399
Compare
I rebasing and fix conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Fixes hashicorp/terraform#15706. Fixes hashicorp#1314. A recent pull request hashicorp#899) accessed `lifecycleRule.Filter` without first ensuring that it is not a `nil` pointer.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Enhance aws_s3_bucket resource, lifecycle_rule.
https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUTlifecycle.html
Link #618, #675, #703, hashicorp/terraform#13680