Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/s3_bucket: Support lifecycle tags filter #899

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

kjmkznr
Copy link
Contributor

@kjmkznr kjmkznr commented Jun 17, 2017

Enhance aws_s3_bucket resource, lifecycle_rule.

  • Add tags filter in lifecycle_rule
  • Change prefix filter to optional

https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUTlifecycle.html

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_Lifecycle'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSS3Bucket_Lifecycle -timeout 120m
=== RUN   TestAccAWSS3Bucket_Lifecycle
--- PASS: TestAccAWSS3Bucket_Lifecycle (68.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       68.349s

Link #618, #675, #703, hashicorp/terraform#13680

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 19, 2017
@kjmkznr kjmkznr changed the title aws_s3_bucket: Support lifecycle tags filter resource/s3_bucket: Support lifecycle tags filter Jun 19, 2017
@enspencer
Copy link
Contributor

+1 Would love to see this merged.

@bdashrad
Copy link

Leaving this outstanding has been holding us up for months, we have to do targeted runs to avoid effecting our lifecycle rules on a managed s3 bucket.

@CoryShiraishi
Copy link

CoryShiraishi commented Jun 21, 2017

+1, would also love to see this merged. Not having this is blocking our adoption of terraform.

@radeksimko
Copy link
Member

Hi @kjmkznr
thank you for this PR, would you mind rebasing it & resolving conflicts? Then I'm happy to take a look & review.

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 25, 2017
@kjmkznr kjmkznr force-pushed the f-aws-s3-bucket-lifecycle-tag branch from aeaf81e to 3a38399 Compare June 25, 2017 15:29
@kjmkznr
Copy link
Contributor Author

kjmkznr commented Jun 25, 2017

I rebasing and fix conflicts.
Please review.

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 25, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@radeksimko radeksimko merged commit f14e748 into hashicorp:master Jun 30, 2017
@joshuaspence joshuaspence mentioned this pull request Aug 3, 2017
jocgir pushed a commit to coveooss/terraform-provider-aws that referenced this pull request Aug 28, 2017
Fixes hashicorp/terraform#15706. Fixes hashicorp#1314. A recent pull request hashicorp#899) accessed `lifecycleRule.Filter` without first ensuring that it is not a `nil` pointer.
@kjmkznr kjmkznr deleted the f-aws-s3-bucket-lifecycle-tag branch November 25, 2018 12:41
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants