Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support resource tags for aws codepipeline resources #8993

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8650

Release note for CHANGELOG:

add support `tags` attribute for `aws_codepipeline` and `aws_codepipeline_webhook`

Output from acceptance testing:

  • r/aws_codepipeline
$  make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodePipeline_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSCodePipeline_ -timeout 120m
=== RUN   TestAccAWSCodePipeline_Import_basic
=== PAUSE TestAccAWSCodePipeline_Import_basic
=== RUN   TestAccAWSCodePipeline_basic
=== PAUSE TestAccAWSCodePipeline_basic
=== RUN   TestAccAWSCodePipeline_emptyArtifacts
=== PAUSE TestAccAWSCodePipeline_emptyArtifacts
=== RUN   TestAccAWSCodePipeline_deployWithServiceRole
=== PAUSE TestAccAWSCodePipeline_deployWithServiceRole
=== RUN   TestAccAWSCodePipeline_tags
=== PAUSE TestAccAWSCodePipeline_tags
=== CONT  TestAccAWSCodePipeline_Import_basic
=== CONT  TestAccAWSCodePipeline_tags
=== CONT  TestAccAWSCodePipeline_deployWithServiceRole
=== CONT  TestAccAWSCodePipeline_emptyArtifacts
=== CONT  TestAccAWSCodePipeline_basic
--- PASS: TestAccAWSCodePipeline_Import_basic (57.18s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (57.32s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (69.09s)
--- PASS: TestAccAWSCodePipeline_basic (88.46s)
--- PASS: TestAccAWSCodePipeline_tags (131.31s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws    131.400s
  • r/aws_codepipeline_webhook
$  make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodePipelineWebhook_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSCodePipelineWebhook_ -timeout 120m
=== RUN   TestAccAWSCodePipelineWebhook_basic
--- PASS: TestAccAWSCodePipelineWebhook_basic (60.90s)
=== RUN   TestAccAWSCodePipelineWebhook_ipAuth
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (61.42s)
=== RUN   TestAccAWSCodePipelineWebhook_unauthenticated
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (59.44s)
=== RUN   TestAccAWSCodePipelineWebhook_tags
--- PASS: TestAccAWSCodePipelineWebhook_tags (141.91s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws    323.783s

@ghost ghost added service/codepipeline Issues and PRs that pertain to the codepipeline service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jun 14, 2019
@bflad bflad self-assigned this Jun 18, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 18, 2019
@bflad bflad added this to the v2.16.0 milestone Jun 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much, @kterada0509 🚀

--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (23.66s)
--- PASS: TestAccAWSCodePipeline_Import_basic (26.33s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (27.36s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (30.96s)
--- PASS: TestAccAWSCodePipeline_tags (34.15s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (38.80s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (39.69s)
--- PASS: TestAccAWSCodePipeline_basic (44.56s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (48.15s)

@bflad bflad merged commit 2b31892 into hashicorp:master Jun 18, 2019
bflad added a commit that referenced this pull request Jun 18, 2019
@bflad
Copy link
Contributor

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
@teraken0509 teraken0509 deleted the feature/add-support-resource-tags-for-aws_codepipeline-resources branch March 5, 2020 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CodePipeline tagging
2 participants