Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ses_receipt_rule_set: Prevent missing Terraform state for newly created resources #9045

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 19, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6470

Prefer the direct DescribeReceiptRuleSet API call over the ListReceiptRuleSets API call for the Read function. Certain APIs have eventual consistency delays with list API calls and here we can refactor away all the additional logic as well.

Release note for CHANGELOG:

resource/aws_ses_receipt_rule_set: Prevent missing Terraform state for newly created resources

Output from acceptance testing:

--- PASS: TestAccAWSSESReceiptRuleSet_basic (9.20s)

…r newly created resources

Reference: #6470

Prefer the direct `DescribeReceiptRuleSet` API call over the `ListReceiptRuleSets` API call for the `Read` function. Certain APIs have eventual consistency delays with list API calls and here we can refactor away all the additional logic as well.

Output from acceptance testing:

```
--- PASS: TestAccAWSSESReceiptRuleSet_basic (9.20s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/ses Issues and PRs that pertain to the ses service. labels Jun 19, 2019
@bflad bflad requested a review from a team June 19, 2019 04:05
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 19, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 🚢 🚀

@bflad bflad added this to the v2.16.0 milestone Jun 19, 2019
@bflad bflad merged commit 30d5ca1 into master Jun 19, 2019
@bflad bflad deleted the b-aws_ses_receipt_rule_set-list branch June 19, 2019 14:00
pull bot pushed a commit to jamesrgregg/terraform-provider-aws that referenced this pull request Jun 19, 2019
@bflad
Copy link
Contributor Author

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ses Issues and PRs that pertain to the ses service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while creating and updating aws_ses_receipt_rule_set
2 participants