Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when setting opsworks permission #9055

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_opsworks_permission: Improves error handing when setting opsworks permissions

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSOpsworksPermission_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSOpsworksPermission_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSOpsworksPermission_basic
=== PAUSE TestAccAWSOpsworksPermission_basic
=== CONT  TestAccAWSOpsworksPermission_basic
--- PASS: TestAccAWSOpsworksPermission_basic (167.64s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       170.034s

@ryndaniels ryndaniels added bug Addresses a defect in current functionality. service/opsworks Issues and PRs that pertain to the opsworks service. labels Jun 19, 2019
@ryndaniels ryndaniels requested a review from bflad June 19, 2019 16:35
@bflad bflad self-assigned this Jun 20, 2019
@bflad bflad added this to the v2.16.0 milestone Jun 20, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

--- PASS: TestAccAWSOpsworksPermission_basic (49.45s)

@bflad bflad assigned ryndaniels and unassigned bflad Jun 20, 2019
@ryndaniels ryndaniels merged commit d5bfe7e into master Jun 20, 2019
@ryndaniels ryndaniels deleted the rfd-retry-opsworks branch June 20, 2019 08:20
@bflad
Copy link
Contributor

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/opsworks Issues and PRs that pertain to the opsworks service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants