Timeout retries for ECR resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_ecr_repository: Final retries when reading and deleting ECR repositories
* resource/aws_ecr_repository_policy: Final retries when creating and updating ECR repository policies

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSEcrRepository"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEcrRepository -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEcrRepositoryPolicy_basic
=== PAUSE TestAccAWSEcrRepositoryPolicy_basic
=== RUN   TestAccAWSEcrRepositoryPolicy_iam
=== PAUSE TestAccAWSEcrRepositoryPolicy_iam
=== RUN   TestAccAWSEcrRepository_basic
=== PAUSE TestAccAWSEcrRepository_basic
=== RUN   TestAccAWSEcrRepository_tags
=== PAUSE TestAccAWSEcrRepository_tags
=== CONT  TestAccAWSEcrRepositoryPolicy_basic
=== CONT  TestAccAWSEcrRepository_tags
=== CONT  TestAccAWSEcrRepositoryPolicy_iam
=== CONT  TestAccAWSEcrRepository_basic
--- PASS: TestAccAWSEcrRepository_basic (27.12s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (30.13s)
--- PASS: TestAccAWSEcrRepository_tags (40.61s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (41.20s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       43.083s

make testacc TESTARGS="-run=TestAccAWSEcrRepositoryPolicy"    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEcrRepositoryPolicy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEcrRepositoryPolicy_basic
=== PAUSE TestAccAWSEcrRepositoryPolicy_basic
=== RUN   TestAccAWSEcrRepositoryPolicy_iam
=== PAUSE TestAccAWSEcrRepositoryPolicy_iam
=== CONT  TestAccAWSEcrRepositoryPolicy_basic
=== CONT  TestAccAWSEcrRepositoryPolicy_iam
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (33.12s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (38.91s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       39.698s

[bflad]

LGTM 🚀

--- PASS: TestAccAWSEcrRepository_basic (7.85s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (8.23s)
--- PASS: TestAccAWSEcrRepository_tags (12.15s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (25.45s)

[bflad]

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!