Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_msk_configuration #9088

Merged
merged 1 commit into from
Jul 8, 2019
Merged

New Data Source: aws_msk_configuration #9088

merged 1 commit into from
Jul 8, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 22, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9082

Release note for CHANGELOG:

* **New Data Source:** `aws_msk_configuration`

Output from acceptance testing:

--- PASS: TestAccAWSMskConfigurationDataSource_Name (15.27s)

@bflad
New Data Source: aws_msk_configuration
631a1b3 
Reference: #9082

Output from acceptance testing:

```
--- PASS: TestAccAWSMskConfigurationDataSource_Name (15.27s)
```
@bflad bflad added new-data-source Introduces a new data source. service/kafka Issues and PRs that pertain to the kafka service. labels Jun 22, 2019
@bflad bflad requested a review from a team June 22, 2019 00:40
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 22, 2019
@bflad bflad mentioned this pull request Jun 22, 2019
Closed
@ryndaniels
Copy link
Contributor

LGTM!

[TestAccAWSMskConfigurationDataSource_Name] [Test Output]
=== RUN   TestAccAWSMskConfigurationDataSource_Name
=== PAUSE TestAccAWSMskConfigurationDataSource_Name
=== CONT  TestAccAWSMskConfigurationDataSource_Name
--- PASS: TestAccAWSMskConfigurationDataSource_Name (53.47s)
PASS

ryndaniels
ryndaniels approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bflad bflad added this to the v2.19.0 milestone Jul 8, 2019
@bflad bflad merged commit a24712f into master Jul 8, 2019
@bflad bflad deleted the f-aws_msk_configuration-data-source branch July 8, 2019 12:31
bflad added a commit that referenced this pull request Jul 8, 2019
@bflad
Update CHANGELOG for #9088
94dc453
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafka Issues and PRs that pertain to the kafka service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

MSK cluster destroy doesn't remove aws_msk_configuration
2 participants
@bflad @ryndaniels