Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/alb_target_group: Add support for UDP protocol #9111

Merged
merged 1 commit into from
Jun 25, 2019
Merged

resource/alb_target_group: Add support for UDP protocol #9111

merged 1 commit into from
Jun 25, 2019

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 24, 2019 •
edited
Loading

Fixes: #9109

All this does is to restrict the validation in the protocol and updates the documentation. AFACIT, there are no other specific changes required for UDP LoadBalancers

If someone does notice differences, then we can easily add them

▶ acctests aws TestAccAWSLBTargetGroup_basicUdp
=== RUN   TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== CONT  TestAccAWSLBTargetGroup_basicUdp
--- PASS: TestAccAWSLBTargetGroup_basicUdp (59.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.888s

▶ acctests aws TestAccAWSLBListener_basicUdp
=== RUN   TestAccAWSLBListener_basicUdp
=== PAUSE TestAccAWSLBListener_basicUdp
=== CONT  TestAccAWSLBListener_basicUdp
--- PASS: TestAccAWSLBListener_basicUdp (292.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	292.138s

@stack72 stack72 requested a review from a team June 24, 2019 19:46
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Jun 24, 2019
@stack72 stack72 force-pushed the stack72/elbv2-udp branch from 737adb2 to b77b088 Compare June 24, 2019 19:48
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jun 24, 2019
@stack72 stack72 changed the title [WIP] resource/alb_target_group: Add support for UDP protocol resource/alb_target_group: Add support for UDP protocol Jun 24, 2019
@bflad bflad added this to the v2.17.0 milestone Jun 24, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 24, 2019
@bflad
Copy link
Contributor

bflad commented Jun 24, 2019

@stack72 fantastic, thanks! Adding this to this week's release. Would you mind adding a quick copy-paste acceptance test for the new UDP support? ❤️

@stack72
Copy link
Contributor Author

stack72 commented Jun 24, 2019

@bflad sude - give me 5 mins to add and test one!

@bflad bflad self-assigned this Jun 24, 2019
@stack72 stack72 force-pushed the stack72/elbv2-udp branch from b77b088 to 86cbcc2 Compare June 24, 2019 20:26
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 24, 2019
@stack72
Copy link
Contributor Author

stack72 commented Jun 24, 2019

Sorry, had an issue but I just pushed 2 tests and updated the comments

@stack72 stack72 force-pushed the stack72/elbv2-udp branch 3 times, most recently from e5e04f1 to c9a6ad9 Compare June 24, 2019 20:31
@stack72 stack72 force-pushed the stack72/elbv2-udp branch from c9a6ad9 to e33c76b Compare June 24, 2019 20:54
bflad
bflad approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor thing. 🚀 Thanks so much, @stack72!

--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (4.61s)
--- FAIL: TestAccAWSLBListener_BackwardsCompatibility (21.17s)
--- PASS: TestAccAWSLBListenerRule_basic (184.74s)
--- PASS: TestAccAWSLBListenerRule_redirect (185.49s)
--- PASS: TestAccAWSLBListener_basic (186.35s)
--- PASS: TestAccAWSLBListener_https (199.16s)
--- PASS: TestAccAWSLBListener_cognito (204.01s)
--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (206.63s)
--- PASS: TestAccAWSLBListener_fixedResponse (213.71s)
--- PASS: TestAccAWSLBListener_redirect (213.88s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (214.30s)
--- PASS: TestAccAWSLBTargetGroup_basic (10.44s)
--- PASS: TestAccAWSLBListenerRule_cognito (219.60s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (7.71s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (11.06s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (229.04s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (23.62s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (231.02s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (231.19s)
--- PASS: TestAccAWSLBTargetGroupBackwardsCompatibility (10.06s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (12.14s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (237.65s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (218.80s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (25.83s)
--- PASS: TestAccAWSLBListener_oidc (236.57s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (17.35s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (27.89s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (37.13s)
--- PASS: TestAccAWSLBListenerRule_oidc (252.69s)
--- PASS: TestAccAWSLBListener_basicUdp (254.78s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (4.26s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (17.90s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (258.11s)
--- PASS: TestAccAWSLBTargetGroupAttachmentBackwardsCompatibility (76.26s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (32.89s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (80.61s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (26.04s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (20.87s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (37.34s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (39.34s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (40.48s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (24.73s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (32.71s)
--- PASS: TestAccAWSLBTargetGroup_tags (36.06s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (42.46s)
--- PASS: TestAccAWSLBTargetGroupAttachment_withoutPort (93.57s)
--- PASS: TestAccAWSLBListenerRule_priority (298.02s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (181.15s)

aws/resource_aws_lb_listener_test.go Show resolved Hide resolved
@bflad bflad merged commit 5565b11 into hashicorp:master Jun 25, 2019
bflad added a commit that referenced this pull request Jun 25, 2019
@bflad
Update CHANGELOG for #9111
5de4758
bflad added a commit that referenced this pull request Jun 25, 2019
@bflad
tests/resource/aws_lb_listener: Revert testAccAWSLBListenerConfigBack…
153a745 
…wardsCompatibility configuration update

Reference: #9111 (comment)
@stack72 stack72 deleted the stack72/elbv2-udp branch June 25, 2019 15:56
@bflad
Copy link
Contributor

bflad commented Jun 28, 2019

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging this pull request may close these issues.

Network Load Balancer now supports UDP protocol
2 participants
@stack72 @bflad