Add timeouts for create and delete and refactor to use isAWSErr

[res0nance]

Add timeouts for create and delete and refactor to use isAWSErr
This contribution is made by Autodesk Inc. under the terms of the Mozilla Public License (MPL) version 2.0.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8043
Release note for CHANGELOG:

- Add timeout option for ebs snapshots

Output from acceptance testing:

root@3687e71f78a7:/aws# make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSSnapshot_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSEBSSnapshot_ -timeout 120m
=== RUN   TestAccAWSEBSSnapshot_basic
=== PAUSE TestAccAWSEBSSnapshot_basic
=== RUN   TestAccAWSEBSSnapshot_withDescription
=== PAUSE TestAccAWSEBSSnapshot_withDescription
=== RUN   TestAccAWSEBSSnapshot_withKms
=== PAUSE TestAccAWSEBSSnapshot_withKms
=== CONT  TestAccAWSEBSSnapshot_basic
=== CONT  TestAccAWSEBSSnapshot_withKms
=== CONT  TestAccAWSEBSSnapshot_withDescription
--- PASS: TestAccAWSEBSSnapshot_withDescription (92.29s)
--- PASS: TestAccAWSEBSSnapshot_withKms (149.37s)
--- PASS: TestAccAWSEBSSnapshot_basic (168.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       168.832s
...

[res0nance]

Log from sample test run snapid redacted

aws_ebs_snapshot.default: Still creating... (20m0s elapsed)
aws_ebs_snapshot.default: Still creating... (20m10s elapsed)
aws_ebs_snapshot.default: Still creating... (20m20s elapsed)
aws_ebs_snapshot.default: Still creating... (20m30s elapsed)
aws_ebs_snapshot.default: Still creating... (20m40s elapsed)
aws_ebs_snapshot.default: Still creating... (20m50s elapsed)
aws_ebs_snapshot.default: Still creating... (21m0s elapsed)
aws_ebs_snapshot.default: Still creating... (21m10s elapsed)
aws_ebs_snapshot.default: Still creating... (21m20s elapsed)
aws_ebs_snapshot.default: Creation complete after 21m27s (ID: snap-xxxx)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

snapshot_id = snap-xxxx

[bflad]

LGTM, thanks @res0nance 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEBSSnapshot_withDescription (35.30s)
--- PASS: TestAccAWSEBSSnapshot_withKms (69.61s)
--- PASS: TestAccAWSEBSSnapshot_basic (116.31s)

Output from acceptance testing in AWS GovCloud (US) (test failure unrelated):

--- PASS: TestAccAWSEBSSnapshot_withDescription (28.75s)
--- FAIL: TestAccAWSEBSSnapshot_withKms (47.25s)
--- PASS: TestAccAWSEBSSnapshot_basic (75.41s)

[bflad]

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!