Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_db_instance: Prevent InvalidParameterCombination: No modifications were requested error when updating only allow_major_version_upgrade argument #9193

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 1, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #500

Release note for CHANGELOG:

* resource/aws_db_instance: Prevent `InvalidParameterCombination: No modifications were requested` error when updating only `allow_major_version_upgrade` argument

Previous output from updated acceptance testing:

--- FAIL: TestAccAWSDBInstance_AllowMajorVersionUpgrade (491.43s)
    testing.go:568: Step 2 error: errors during apply:

        Error: Error modifying DB Instance tf-acc-test-4576888905000364877: InvalidParameterCombination: No modifications were requested

Output from acceptance testing:

--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (433.02s)

…ifications were requested error when updating only allow_major_version_upgrade argument

Reference: #500

Previous output from updated acceptance testing:

```
--- FAIL: TestAccAWSDBInstance_AllowMajorVersionUpgrade (491.43s)
    testing.go:568: Step 2 error: errors during apply:

        Error: Error modifying DB Instance tf-acc-test-4576888905000364877: InvalidParameterCombination: No modifications were requested
```

Output from acceptance testing:

```
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (433.02s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Jul 1, 2019
@bflad bflad requested a review from a team July 1, 2019 20:44
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 1, 2019
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick, but feel free to ping me to approve it again if you think that makes sense!

aws/resource_aws_db_instance.go Outdated Show resolved Hide resolved
Co-Authored-By: Gauthier Wallet <gauthier.wallet@gmail.com>
@bflad bflad added this to the v2.18.0 milestone Jul 2, 2019
@bflad bflad merged commit 69fd743 into master Jul 2, 2019
@bflad bflad deleted the b-aws_db_instance-allow_major_version_update-modify branch July 2, 2019 13:50
bflad added a commit that referenced this pull request Jul 2, 2019
@bflad
Copy link
Contributor Author

bflad commented Jul 5, 2019

This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS RDS: TF tries to update allow_major_version_upgrade on its own and fails
2 participants