-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: aws_apigatewayv2_authorizer #9228
New resource: aws_apigatewayv2_authorizer #9228
Conversation
afed9d2
to
8439df3
Compare
8439df3
to
5f5e59c
Compare
5f5e59c
to
9777911
Compare
Rebased to fix merge conflict. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Authorizer_ -timeout 120m
=== RUN TestAccAWSAPIGateway2Authorizer_basic
=== PAUSE TestAccAWSAPIGateway2Authorizer_basic
=== RUN TestAccAWSAPIGateway2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGateway2Authorizer_Credentials
=== CONT TestAccAWSAPIGateway2Authorizer_basic
=== CONT TestAccAWSAPIGateway2Authorizer_Credentials
--- PASS: TestAccAWSAPIGateway2Authorizer_basic (46.21s)
--- PASS: TestAccAWSAPIGateway2Authorizer_Credentials (76.36s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 76.402s |
Re-ran acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Authorizer_ -timeout 120m
=== RUN TestAccAWSAPIGateway2Authorizer_basic
=== PAUSE TestAccAWSAPIGateway2Authorizer_basic
=== RUN TestAccAWSAPIGateway2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGateway2Authorizer_Credentials
=== CONT TestAccAWSAPIGateway2Authorizer_basic
=== CONT TestAccAWSAPIGateway2Authorizer_Credentials
--- PASS: TestAccAWSAPIGateway2Authorizer_basic (39.61s)
--- PASS: TestAccAWSAPIGateway2Authorizer_Credentials (76.55s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 76.577s |
After merge of #8842, incorporate all the feedback:
|
75b0f33
to
c7d98c0
Compare
Renamed resource to $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Authorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Authorizer_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2Authorizer_basic
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_basic
=== RUN TestAccAWSAPIGatewayV2Authorizer_disappears
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_disappears
=== RUN TestAccAWSAPIGatewayV2Authorizer_Credentials
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_Credentials
=== CONT TestAccAWSAPIGatewayV2Authorizer_basic
=== CONT TestAccAWSAPIGatewayV2Authorizer_Credentials
=== CONT TestAccAWSAPIGatewayV2Authorizer_disappears
--- PASS: TestAccAWSAPIGatewayV2Authorizer_disappears (49.76s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_basic (63.81s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_Credentials (104.46s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 104.529s |
d081af9
to
10d45d7
Compare
Added support for JWT authorizers for HTTP APIs. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Authorizer_JWT'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Authorizer_JWT -timeout 120m
=== RUN TestAccAWSAPIGatewayV2Authorizer_JWT
=== PAUSE TestAccAWSAPIGatewayV2Authorizer_JWT
=== CONT TestAccAWSAPIGatewayV2Authorizer_JWT
--- PASS: TestAccAWSAPIGatewayV2Authorizer_JWT (66.65s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 66.690s |
f7fe90f
to
7178b17
Compare
7178b17
to
4c27f54
Compare
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSAPIGatewayV2Authorizer_JWT (32.45s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_disappears (39.37s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_basic (40.71s)
--- PASS: TestAccAWSAPIGatewayV2Authorizer_Credentials (51.02s)
This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Another resource for #7004.
Release note for CHANGELOG:
Output from acceptance testing:
Currently based on #8842, will need to rebase once that PR is merged.