Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: Support AWS AD service Log subscription #9261

Merged
merged 3 commits into from
Jul 10, 2019
Merged

New Resource: Support AWS AD service Log subscription #9261

merged 3 commits into from
Jul 10, 2019

Conversation

johnthedev97
Copy link
Contributor

@johnthedev97 johnthedev97 commented Jul 7, 2019 •
edited
Loading

Add capability to enable/configure the Cloudwatch Log to Directory Service (#9069)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #0000

Release note for CHANGELOG:

resource/aws_directory_service_log_subscription: Adding support to enable/disable log subscription for Directory service

Output from acceptance testing:

make testacc TEST=./aws TESTARGS="-run=TestAccAWSDirectoryServiceLogSubscription_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDirectoryServiceLogSubscription_ -timeout 120m
=== RUN   TestAccAWSDirectoryServiceLogSubscription_basic
=== PAUSE TestAccAWSDirectoryServiceLogSubscription_basic
=== CONT  TestAccAWSDirectoryServiceLogSubscription_basic
--- PASS: TestAccAWSDirectoryServiceLogSubscription_basic (1755.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1755.628s
...

@johnthedev97 johnthedev97 requested a review from a team July 7, 2019 21:53
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/directoryservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 7, 2019
@johnthedev97 johnthedev97 changed the title [WIP] support AWS AD service Log subscription New Resource: Support AWS AD service Log subscription Jul 7, 2019
bflad
bflad suggested changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnthedev97 👋 Thanks for submitting this, its off to a great start. Please see the below initial feedback and let us know if you have any questions or do not have time to implement the items.

aws/provider.go Show resolved Hide resolved
aws/resource_aws_directory_service_log_subscription.go Outdated Show resolved Hide resolved
aws/resource_aws_directory_service_log_subscription.go Outdated Show resolved Hide resolved
aws/resource_aws_directory_service_log_subscription.go Outdated Show resolved Hide resolved
aws/resource_aws_directory_service_log_subscription.go Outdated Show resolved Hide resolved
aws/resource_aws_directory_service_log_subscription.go Show resolved Hide resolved
@bflad bflad added new-resource Introduces a new resource. waiting-response Maintainers are waiting on response from community or contributor. labels Jul 9, 2019
@bflad bflad self-assigned this Jul 9, 2019
@crjohn
Review comment fixes
aa9f303 
	Updated the error returns to be descriptive
	Added the documentation links
	Removed the update function
	Set Id to empty if read fails
	Whitespace changes in test code
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 10, 2019
@johnthedev97
Copy link
Contributor Author

Hi @bflad I have made the changes you requested, please check

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 10, 2019
bflad
bflad approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @johnthedev97! Looks good. 🚀

--- PASS: TestAccAWSDirectoryServiceLogSubscription_basic (1747.51s)

aws/resource_aws_directory_service_log_subscription_test.go
}

tags = {
Name = "terraform-testacc-directory-service-conditional-forwarder"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor copy-paste error -- will fix on merge 👍

website/docs/r/directory_service_log_subscription.html.markdown

## Import

Conditional forwarders can be imported using the directory id and remote_domain_name, e.g.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor copy-paste error -- will fix on merge 👍

@bflad bflad added this to the v2.19.0 milestone Jul 10, 2019
@bflad bflad merged commit c4af1c4 into hashicorp:master Jul 10, 2019
bflad added a commit that referenced this pull request Jul 10, 2019
@bflad
Update CHANGELOG for #9261
1c0d232
@johnthedev97
Copy link
Contributor Author

Thanks @bflad for those fixes

@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnthedev97 @bflad @crjohn