Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_db_event_subscription: Prevent Unable to find RDS Event Subscription error during deletion and refresh #9274

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 9, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9243

Release note for CHANGELOG:

* resource/aws_db_event_subscription: Prevent `Unable to find RDS Event Subscription` error during deletion and refresh

Output from acceptance testing:

--- PASS: TestAccAWSDBEventSubscription_disappears (77.59s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (78.54s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (79.44s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (90.38s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (116.80s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (117.48s)

@bflad bflad added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Jul 9, 2019
@bflad bflad added this to the v2.19.0 milestone Jul 9, 2019
@bflad bflad requested a review from a team July 9, 2019 01:17
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 9, 2019
… Subscription` error during deletion and refresh

Reference: #9243

Output from acceptance testing:

```
--- PASS: TestAccAWSDBEventSubscription_disappears (77.59s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (78.54s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (79.44s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (90.38s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (116.80s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (117.48s)
```
@bflad bflad force-pushed the b-aws_db_event_subscription-deletion branch from d998d75 to 0fcd6c5 Compare July 9, 2019 01:25
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

--- PASS: TestAccAWSDBEventSubscription_disappears (77.74s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (80.73s)
--- PASS: TestAccAWSDBEventSubscription_importBasic (82.04s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (96.98s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (123.45s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (124.53s)

@bflad bflad merged commit a2c5f3e into master Jul 10, 2019
@bflad bflad deleted the b-aws_db_event_subscription-deletion branch July 10, 2019 00:15
bflad added a commit that referenced this pull request Jul 10, 2019
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_db_event_subscription deletion is failing with Error deleting RDS Event Subscription
2 participants