Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_iam_policy_attachment: Bypass NoSuchEntity error when detaching groups, roles, and users (support group, role, and user renames) #9278

Merged
merged 3 commits into from
Jul 10, 2019
Merged

resource/aws_iam_policy_attachment: Bypass NoSuchEntity error when detaching groups, roles, and users (support group, role, and user renames) #9278

merged 3 commits into from
Jul 10, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 9, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5417

Release note for CHANGELOG:

* resource/aws_iam_policy_attachment: Bypass `NoSuchEntity` error when detaching groups, roles, and users (support group, role, and user renames)

Previously from acceptance testing (before code updates):

--- FAIL: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (8.82s)
    testing.go:568: Step 1 error: errors during apply:

        Error: [WARN] Error updating user, role, or group list from IAM Policy Attachment tf-acc-test-5552018730471644331:
        – NoSuchEntity: The group with name tf-acc-test-5552018730471644331-1 cannot be found.

--- FAIL: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (10.31s)
    testing.go:568: Step 1 error: errors during apply:

        Error: [WARN] Error updating user, role, or group list from IAM Policy Attachment tf-acc-test-4256997168279122998:
        – NoSuchEntity: The role with name tf-acc-test-4256997168279122998-1 cannot be found.

--- FAIL: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (11.64s)
    testing.go:568: Step 1 error: errors during apply:

        Error: [WARN] Error updating user, role, or group list from IAM Policy Attachment tf-acc-test-5706224507827321055:
        – NoSuchEntity: The user with name tf-acc-test-5706224507827321055-1 cannot be found.

Output from acceptance testing:

--- PASS: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (12.29s)
--- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (12.51s)
--- PASS: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (12.92s)
--- PASS: TestAccAWSIAMPolicyAttachment_basic (137.55s)
--- PASS: TestAccAWSIAMPolicyAttachment_paginatedEntities (216.36s)

bflad added 3 commits July 9, 2019 01:47
@bflad
resource/aws_iam_policy_attachment: Bypass NoSuchEntity error when …
5110563 
…detaching groups, roles, and users (support group, role, and user renames)

Reference: #5417

Previously from acceptance testing (before code updates):

```
--- FAIL: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (8.82s)
    testing.go:568: Step 1 error: errors during apply:

        Error: [WARN] Error updating user, role, or group list from IAM Policy Attachment tf-acc-test-5552018730471644331:
        – NoSuchEntity: The group with name tf-acc-test-5552018730471644331-1 cannot be found.

--- FAIL: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (10.31s)
    testing.go:568: Step 1 error: errors during apply:

        Error: [WARN] Error updating user, role, or group list from IAM Policy Attachment tf-acc-test-4256997168279122998:
        – NoSuchEntity: The role with name tf-acc-test-4256997168279122998-1 cannot be found.

--- FAIL: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (11.64s)
    testing.go:568: Step 1 error: errors during apply:

        Error: [WARN] Error updating user, role, or group list from IAM Policy Attachment tf-acc-test-5706224507827321055:
        – NoSuchEntity: The user with name tf-acc-test-5706224507827321055-1 cannot be found.
```

Output from acceptance testing:

```
--- PASS: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (12.29s)
--- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (12.51s)
--- PASS: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (12.92s)
--- PASS: TestAccAWSIAMPolicyAttachment_basic (137.55s)
--- PASS: TestAccAWSIAMPolicyAttachment_paginatedEntities (216.36s)
```
@bflad
docs/resource/aws_iam_role: Note force_detach_policies argument requi…
4bef877 
…rement for modifying name/path with aws_iam_policy_attachment

Reference: #5417
@bflad
docs/resource/aws_iam_user: Note force_destroy argument requirement f…
a339018 
…or modifying name/path with aws_iam_policy_attachment

Reference: #5417
@bflad bflad added bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. labels Jul 9, 2019
@bflad bflad requested a review from a team July 9, 2019 05:50
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 9, 2019
@bflad bflad mentioned this pull request Jul 9, 2019
Closed
nywilken
nywilken approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

--- PASS: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (25.97s)
--- PASS: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (26.31s)
--- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (27.80s)
--- PASS: TestAccAWSIAMPolicyAttachment_basic (35.83s)
--- PASS: TestAccAWSIAMPolicyAttachment_paginatedEntities (274.93s)

@bflad bflad added this to the v2.19.0 milestone Jul 10, 2019
@bflad bflad merged commit 33dd74b into master Jul 10, 2019
@bflad bflad deleted the b-aws_iam_policy_attachment-ignore-NoSuchEntity branch July 10, 2019 00:20
bflad added a commit that referenced this pull request Jul 10, 2019
@bflad
Update CHANGELOG for #9278
db7036e
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

Can't delete IAM role because policies are attached
2 participants
@bflad @nywilken