Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_wafregional_rule: Add WAFRegional Rule lookup datasource #9319

Merged
merged 5 commits into from
Jul 18, 2019
Merged

d/aws_wafregional_rule: Add WAFRegional Rule lookup datasource #9319

merged 5 commits into from
Jul 18, 2019

Conversation

robh007
Copy link
Contributor

@robh007 robh007 commented Jul 12, 2019 •
edited by ryndaniels
Loading

AWS WAFRegional Rule datasource

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #2654

Release note for CHANGELOG:

** New datasource ** `aws_wafregional_rule`

Output from acceptance testing:

$ make testacc ./aws TESTARGS='-run=TestAccDataSourceAwsWafRegionalRule'
--- PASS: TestAccDataSourceAwsWafRegionalRule_Basic (21.76s)

...

@robh007 robh007 requested a review from a team July 12, 2019 11:15
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 12, 2019
@bflad bflad added the new-data-source Introduces a new data source. label Jul 12, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 17, 2019
@robh007
Copy link
Contributor Author

robh007 commented Jul 17, 2019

Updated tests inline with feedback from #9321

make testacc ./aws TESTARGS='-run=TestAccDataSourceAwsWafRegionalRule'
--- PASS: TestAccDataSourceAwsWafRule_Basic (21.83s)

ryndaniels
ryndaniels approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @robh007, thanks! 🚀

Output from acceptance testing:

[TestAccDataSourceAwsWafRegionalRule_Basic] [Test Output]
=== RUN   TestAccDataSourceAwsWafRegionalRule_Basic
=== PAUSE TestAccDataSourceAwsWafRegionalRule_Basic
=== CONT  TestAccDataSourceAwsWafRegionalRule_Basic
--- PASS: TestAccDataSourceAwsWafRegionalRule_Basic (9.73s)
PASS

@ryndaniels ryndaniels added this to the v2.20.0 milestone Jul 18, 2019
@ryndaniels ryndaniels merged commit 55e56a0 into hashicorp:master Jul 18, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees

@ryndaniels ryndaniels

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robh007 @ryndaniels @bflad