Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_apigatewayv2_route_response #9373

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_api_gateway_v2_route_response (#7004)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2RouteResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2RouteResponse_basic
=== PAUSE TestAccAWSAPIGateway2RouteResponse_basic
=== RUN   TestAccAWSAPIGateway2RouteResponse_Model
=== PAUSE TestAccAWSAPIGateway2RouteResponse_Model
=== CONT  TestAccAWSAPIGateway2RouteResponse_basic
=== CONT  TestAccAWSAPIGateway2RouteResponse_Model
--- PASS: TestAccAWSAPIGateway2RouteResponse_basic (22.80s)
--- PASS: TestAccAWSAPIGateway2RouteResponse_Model (31.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.150s

Currently based on #8842, will need to rebase once that PR is merged.

@ewbankkit ewbankkit requested a review from a team July 16, 2019 22:08
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 16, 2019
@ewbankkit
Copy link
Contributor Author

Includes

@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route_response branch from e113abc to 7438625 Compare July 26, 2019 21:19
@ewbankkit
Copy link
Contributor Author

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2RouteResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2RouteResponse_basic
=== PAUSE TestAccAWSAPIGateway2RouteResponse_basic
=== RUN   TestAccAWSAPIGateway2RouteResponse_Model
=== PAUSE TestAccAWSAPIGateway2RouteResponse_Model
=== CONT  TestAccAWSAPIGateway2RouteResponse_basic
=== CONT  TestAccAWSAPIGateway2RouteResponse_Model
--- PASS: TestAccAWSAPIGateway2RouteResponse_basic (22.98s)
--- PASS: TestAccAWSAPIGateway2RouteResponse_Model (24.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.096s

@ewbankkit
Copy link
Contributor Author

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2RouteResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2RouteResponse_basic
=== PAUSE TestAccAWSAPIGateway2RouteResponse_basic
=== RUN   TestAccAWSAPIGateway2RouteResponse_Model
=== PAUSE TestAccAWSAPIGateway2RouteResponse_Model
=== CONT  TestAccAWSAPIGateway2RouteResponse_basic
=== CONT  TestAccAWSAPIGateway2RouteResponse_Model
--- PASS: TestAccAWSAPIGateway2RouteResponse_Model (25.63s)
--- PASS: TestAccAWSAPIGateway2RouteResponse_basic (28.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.007s

@aeschright aeschright added the new-resource Introduces a new resource. label Aug 19, 2019
@bflad bflad removed the service/apigateway Issues and PRs that pertain to the apigateway service. label Apr 15, 2020
@ewbankkit
Copy link
Contributor Author

After merge of #8881, incorporate all the feedback:

  • Migrate to Terraform provider SDK
  • Change resource name to aws_apigatewayv2_blah; Rename source files
  • Remove sidebar_current from documentation
  • Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
  • Change function names to ApiGatewayV2
  • Add _disappears acceptance test
  • Use multierror in any test sweeper

@ewbankkit ewbankkit changed the title New resource: aws_api_gateway_v2_route_response New resource: aws_apigatewayv2_route_response Apr 15, 2020
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route_response branch 2 times, most recently from 133dc87 to 7f4eb19 Compare April 15, 2020 13:14
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Apr 15, 2020

Renamed resource to aws_apigatewayv2_route_response.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2RouteResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2RouteResponse_basic
=== PAUSE TestAccAWSAPIGatewayV2RouteResponse_basic
=== RUN   TestAccAWSAPIGatewayV2RouteResponse_disappears
=== PAUSE TestAccAWSAPIGatewayV2RouteResponse_disappears
=== RUN   TestAccAWSAPIGatewayV2RouteResponse_Model
=== PAUSE TestAccAWSAPIGatewayV2RouteResponse_Model
=== CONT  TestAccAWSAPIGatewayV2RouteResponse_basic
=== CONT  TestAccAWSAPIGatewayV2RouteResponse_Model
=== CONT  TestAccAWSAPIGatewayV2RouteResponse_disappears
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_disappears (26.74s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_basic (29.46s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_Model (37.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.991s

@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_route_response branch from 120c212 to 1d45f80 Compare April 15, 2020 17:42
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Apr 15, 2020
@ewbankkit
Copy link
Contributor Author

Ready for review.

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2RouteResponse_disappears (10.32s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_Model (11.73s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_basic (12.51s)

@gdavison gdavison added this to the v2.58.0 milestone Apr 15, 2020
@gdavison gdavison merged commit 127c81c into hashicorp:master Apr 15, 2020
gdavison added a commit that referenced this pull request Apr 15, 2020
@ewbankkit ewbankkit deleted the issue-7004.aws_api_gateway_v2_route_response branch April 15, 2020 19:42
@ghost
Copy link

ghost commented Apr 17, 2020

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants