-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: aws_apigatewayv2_route_response #9373
New resource: aws_apigatewayv2_route_response #9373
Conversation
Includes
|
e113abc
to
7438625
Compare
Rebased to fix merge conflict. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2RouteResponse_ -timeout 120m
=== RUN TestAccAWSAPIGateway2RouteResponse_basic
=== PAUSE TestAccAWSAPIGateway2RouteResponse_basic
=== RUN TestAccAWSAPIGateway2RouteResponse_Model
=== PAUSE TestAccAWSAPIGateway2RouteResponse_Model
=== CONT TestAccAWSAPIGateway2RouteResponse_basic
=== CONT TestAccAWSAPIGateway2RouteResponse_Model
--- PASS: TestAccAWSAPIGateway2RouteResponse_basic (22.98s)
--- PASS: TestAccAWSAPIGateway2RouteResponse_Model (24.08s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 24.096s |
Re-ran acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2RouteResponse_ -timeout 120m
=== RUN TestAccAWSAPIGateway2RouteResponse_basic
=== PAUSE TestAccAWSAPIGateway2RouteResponse_basic
=== RUN TestAccAWSAPIGateway2RouteResponse_Model
=== PAUSE TestAccAWSAPIGateway2RouteResponse_Model
=== CONT TestAccAWSAPIGateway2RouteResponse_basic
=== CONT TestAccAWSAPIGateway2RouteResponse_Model
--- PASS: TestAccAWSAPIGateway2RouteResponse_Model (25.63s)
--- PASS: TestAccAWSAPIGateway2RouteResponse_basic (28.97s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 29.007s |
After merge of #8881, incorporate all the feedback:
|
133dc87
to
7f4eb19
Compare
Renamed resource to $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2RouteResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2RouteResponse_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2RouteResponse_basic
=== PAUSE TestAccAWSAPIGatewayV2RouteResponse_basic
=== RUN TestAccAWSAPIGatewayV2RouteResponse_disappears
=== PAUSE TestAccAWSAPIGatewayV2RouteResponse_disappears
=== RUN TestAccAWSAPIGatewayV2RouteResponse_Model
=== PAUSE TestAccAWSAPIGatewayV2RouteResponse_Model
=== CONT TestAccAWSAPIGatewayV2RouteResponse_basic
=== CONT TestAccAWSAPIGatewayV2RouteResponse_Model
=== CONT TestAccAWSAPIGatewayV2RouteResponse_disappears
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_disappears (26.74s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_basic (29.46s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_Model (37.94s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 37.991s |
120c212
to
1d45f80
Compare
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_disappears (10.32s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_Model (11.73s)
--- PASS: TestAccAWSAPIGatewayV2RouteResponse_basic (12.51s)
This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Another resource for #7004.
Release note for CHANGELOG:
Output from acceptance testing:
Currently based on #8842, will need to rebase once that PR is merged.