-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workgroup support for Athena named query #9383
add workgroup support for Athena named query #9383
Conversation
63bc10c
to
9a5add9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paulhudson 👋 Thanks for contributing this. Its off to a good start, just a few little things and we should be able to get this in. Please reach out if you have any questions or do not have time to implement the feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for those updates as they helped uncover a regression that could have been merged in. Please see the below two small items to fix this up and once the acceptance testing is passing again this is good to go. Thanks!
0500716
to
e016e15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks, @paulhudson 🚀
--- PASS: TestAccAWSAthenaNamedQuery_withWorkGroup (25.40s)
--- PASS: TestAccAWSAthenaNamedQuery_basic (25.47s)
--- PASS: TestAccAWSAthenaNamedQuery_import (25.83s)
The enhancement to the For further feature requests or bug reports with this resource, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8016
Release note for CHANGELOG:
Output from acceptance testing: