Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retry when reading s3 account public access block #9387

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_s3_account_public_access_block: Retry after timeout when reading s3 account public access block

Output from acceptance testing:

These tests have been flaky for a while. This has been noted here [#9386]; opening this PR despite test failures as I'm seeing the same failures on master locally.

@ryndaniels ryndaniels requested a review from a team July 17, 2019 16:47
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/s3control Issues and PRs that pertain to the s3control service. labels Jul 17, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ryndaniels! 🚀

@ryndaniels ryndaniels added this to the v2.20.0 milestone Jul 18, 2019
@ryndaniels ryndaniels merged commit 363051d into master Jul 18, 2019
@ryndaniels ryndaniels deleted the rfd-retry-s3-account branch August 16, 2019 07:38
@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/s3control Issues and PRs that pertain to the s3control service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants