Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple target groups for ecs service #9411

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

sunilkumarmohanty
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9285

Release note for CHANGELOG:

resource/aws_ecs_service: Add support for multiple target groups

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
Not tested yet as the feature is in developer preview
...

@sunilkumarmohanty sunilkumarmohanty requested a review from a team July 18, 2019 19:57
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 18, 2019
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 18, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 18, 2019
@bflad bflad added this to the v2.22.0 milestone Jul 30, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @sunilkumarmohanty. After fixing up the acceptance test so it was successfully passing, LGTM. 🚀

--- PASS: TestAccAWSEcsService_basicImport (75.25s)
--- PASS: TestAccAWSEcsService_disappears (60.03s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (314.63s)
--- PASS: TestAccAWSEcsService_ManagedTags (72.59s)
--- PASS: TestAccAWSEcsService_PropagateTags (179.29s)
--- PASS: TestAccAWSEcsService_Tags (69.95s)
--- PASS: TestAccAWSEcsService_withAlb (319.76s)
--- PASS: TestAccAWSEcsService_withARN (70.79s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (32.19s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (42.09s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (316.26s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (74.12s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (74.14s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (63.57s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (80.06s)
--- PASS: TestAccAWSEcsService_withIamRole (147.85s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (66.61s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (157.35s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (147.03s)
--- PASS: TestAccAWSEcsService_withLbChanges (269.69s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (338.26s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (76.33s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (63.87s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (267.84s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (132.98s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (62.39s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (161.78s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (150.98s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (61.25s)

@bflad bflad merged commit 78b0bf7 into hashicorp:master Jul 30, 2019
bflad added a commit that referenced this pull request Jul 30, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ghost
Copy link

ghost commented Aug 1, 2019

This has been released in version 2.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ECS service registration w/ multiple target groups
2 participants